Fix config toml, go generate #614
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…CBP config fields (*big.Int -> *uint64) Date: 2024-02-05 09:53:17-07:00 Signed-off-by: meows <[email protected]>
…o-ethereum config types Date: 2024-02-05 09:54:38-07:00 Signed-off-by: meows <[email protected]>
…dd missing omitempty tags Date: 2024-02-05 10:01:44-07:00 Signed-off-by: meows <[email protected]>
Date: 2024-02-05 10:04:07-07:00 Signed-off-by: meows <[email protected]>
…tch for core-geth vs. go-ethereum config types Date: 2024-02-05 10:04:35-07:00 Signed-off-by: meows <[email protected]>
Date: 2024-02-05 10:06:16-07:00 Signed-off-by: meows <[email protected]>
diega
approved these changes
Feb 5, 2024
…CBP1100 Date: 2024-02-05 11:00:37-07:00 Signed-off-by: meows <[email protected]>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #613
ethconfig.Configfield data types for ECBP fields. These were*big.Intand should have been*uint64. These data types percolate throughbackend.go.go generatefiles were not up to date, so I ran `go generate -skip=trezor ./...gen_genesis.goto re-implement the config type switch between core-geth and go-ethereum config types (yuck!)workflow_dispatchrun trigger for the go-generate-check workflow, in addition to the existingpull_request