Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorrect implementation of energy delta and specbox for pseudoknots in puzzlemaker #758

Open
luxaritas opened this issue Jul 8, 2024 · 0 comments
Labels
priority: p3/standard Enhancement with nominal value or bug with nominal impact size: md type: bug Something isn't working

Comments

@luxaritas
Copy link
Member

Currently both the energy delta update and specbox update methods in puzzlemaker use targetconditions to determine whether or not to compute with pknots. However, targetconditions is not actually set with this property in puzzlemaker.

However we also can't just fix this, as the specbox update pseudoknot flag not only changes the computation, but also changes how it's stored/retrieved in undoblock. Right now, even if pknots are enabled we store all data in the undoblock marked with pknots as false. This should presumably be changed/fixed, but we need to verify it won't break existing autosaves.

This isn't actually an issue right now since nothing with pknots has energies enabled and all pknot engines use the same dot plots for both pknot and nonpknot cases. However, that could change at some future point, so this should be fixed.

@luxaritas luxaritas added type: bug Something isn't working priority: p3/standard Enhancement with nominal value or bug with nominal impact size: md labels Jul 8, 2024
@luxaritas luxaritas added this to Roadmap Jul 8, 2024
@luxaritas luxaritas moved this to Todo in Roadmap Jul 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
priority: p3/standard Enhancement with nominal value or bug with nominal impact size: md type: bug Something isn't working
Projects
Status: Todo
Development

No branches or pull requests

1 participant