Inconsistent dot plot/pairing probabilities behavior between Vienna/Vienna2 and everything else #803
Labels
priority: p2/important ⚠️
A large number of users have a significant pain point or a significant use case is prevented
size: md
type: bug
Something isn't working
Two issues here:
pairing_probabilities
API to not include the "lower triangle". There also appears to be some cases in our code (eg for expectedAccuracy, pUnp, etc) where we also don't do this correctly!The issue with just fixing it outright is that by this point, a number of eternascript authors have implemented workarounds in their own scripts, which means that scripts that currently behave correctly because of a custom patch (or other reliance on the current behavior) will then behave incorrectly - and script authors who do this may not realize it has been fixed, so continue to rely on the incorrect behavior
We've decided to fix this by:
pairing_probabilities
topairing_probabilities_incorrect
, which will continue to have the current behavior.pairing_probabilities
withpairing_probabilities_incorrect
pairing_probabilities
with the expectation of the old behavior, they find it no longer exists, looks at the docs, and sees there's a new function that behaves differently. I propose calling thisbase_pairing_probabilities
.The text was updated successfully, but these errors were encountered: