Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use environment variables for Vite and Cypress #150

Open
tkaragianes opened this issue Aug 31, 2022 · 0 comments
Open

Use environment variables for Vite and Cypress #150

tkaragianes opened this issue Aug 31, 2022 · 0 comments
Labels
priority: p4/minor There is a reasonable workaround, or there is a nice to have with limited impact scope: cypress-utils scope: nx-plugin scope: vite-utils size: md type: enhancement New feature or request

Comments

@tkaragianes
Copy link
Contributor

We currently hard-code the URL that Vite uses by default into our Cypress generators (see packages/nx-plugin/src/generators/package/cypress/e2e/index.ts for an example). We probably should pass a port in as an environment variable that both Vite and Cypress reference so that we don't run into issues where Vite selects a different port and Cypress doesn't know.
@luxaritas luxaritas mentioned this issue Aug 31, 2022
Merged
@luxaritas luxaritas added priority: p4/minor There is a reasonable workaround, or there is a nice to have with limited impact size: md labels Sep 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
priority: p4/minor There is a reasonable workaround, or there is a nice to have with limited impact scope: cypress-utils scope: nx-plugin scope: vite-utils size: md type: enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@tkaragianes @luxaritas