Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Investigate handling tooling build dependencies via Nx #220

Open
luxaritas opened this issue May 2, 2023 · 0 comments
Open

Investigate handling tooling build dependencies via Nx #220

luxaritas opened this issue May 2, 2023 · 0 comments
Labels
priority: p5/chore 🧹 A cleanup with no end-user impact scope: repo Applicable to general repository upkeep size: md type: ergonomics Tooling, refactoring, etc

Comments

@luxaritas
Copy link
Member

luxaritas commented May 2, 2023

Right now, we have some limitations:

  • We have to set vite-utils as an implicit dependency in all packages
  • We have to build lint-staged-utils first manually in our pre-commit
  • We have to build eslint-plugin first manually in our lint-staged
  • We have to build eslint-plugin and lint-staged-utils first manually in CI
  • If you try to run a lint before building eslint-plugin, it will presumably fail

As of Nx 16, you can specify in a task's dependsOn a task to be run in a specific package. We should be able to combine that with the new ability to define tasks at the root level (which also lets us do things like cache our "core" lint!) to handle this via Nx's dependency management.

@luxaritas luxaritas added type: ergonomics Tooling, refactoring, etc scope: repo Applicable to general repository upkeep priority: p5/chore 🧹 A cleanup with no end-user impact size: md labels May 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
priority: p5/chore 🧹 A cleanup with no end-user impact scope: repo Applicable to general repository upkeep size: md type: ergonomics Tooling, refactoring, etc
Projects
None yet
Development

No branches or pull requests

1 participant