Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disallow Coreset Strategy with Models that don't implement the ´CoresetSupportingModule` #296

Open
MaxiBoether opened this issue Sep 18, 2023 · 0 comments

Comments

@MaxiBoether
Copy link
Contributor

Right now, we have undefined behavior what happens if we use models that do not inherit from CoresetSupportingModule (introduced in #294) and still use a coreset data selection policy. We should add a step that disallows this (potentially together with a better ModynModel abstraction)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant