Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fastify integration #190

Open
StaringSkyward opened this issue Mar 5, 2019 · 3 comments
Open

Fastify integration #190

StaringSkyward opened this issue Mar 5, 2019 · 3 comments

Comments

@StaringSkyward
Copy link

I like the look of https://www.fastify.io/ and would like to create an integration for it. It uses a plugin design which seems pretty different to Express and other examples here, so I'm not sure what form that integration would take... Is this something that would be of any value before I take it on?

@ethanresnick
Copy link
Owner

ethanresnick commented Mar 5, 2019

Take a look at the ExpressStrategy if you haven't already. Honestly, I think it should be pretty similar. The API for fastify's reply object looks about the same. The biggest difference appears to be that fastify request handlers don't take a next argument, so the functions returned from the methods on your new adapter (ie., from apiRequest and all the methods from here downward) won't either.

@StaringSkyward
Copy link
Author

Thanks @ethanresnick, I'll give it a try. I'm coming from Ruby and pretty new to Node so this will be a challenge but really useful to me and others I hope.

@twss
Copy link

twss commented Apr 11, 2019

I'm on it!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants