Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simulating All the PSPs and not only the last one. #72

Open
Ethnical opened this issue Sep 19, 2024 · 0 comments
Open

Simulating All the PSPs and not only the last one. #72

Ethnical opened this issue Sep 19, 2024 · 0 comments
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@Ethnical
Copy link
Collaborator

Ethnical commented Sep 19, 2024

A feature would be to simulate all the PSPs and not only the last one with the last nonce.
This would be a nice improvement in case a future PSPs is broken (mostly because incorrect data inside the PSP) but this is still a good sanity to checks to ensure that all the PSPs are valid.

The plan would be to:

  1. Fork the network using NewSimulatedBackend.
  2. Prefund the address that should be located into the d.senderAddress
  3. Override the d.operationSafe with the nonces for each PSPs and simulate for each PSPs each time.

Additional context
Currently, we are simulating using eth_call as this is sufficient but this is not covering all the PSPs but only the last one.
This also require to trust correctly the node RPC because this send the calldata to the node.

@Ethnical Ethnical added the enhancement New feature or request label Sep 19, 2024
@Ethnical Ethnical added the good first issue Good for newcomers label Oct 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

1 participant