Update ERC-7579: Prefix ERC-7579 interfaces names to avoid conflicts #876
+11
−11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
File
|
eip-review-bot
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ERC-7579 defines multiples interfaces (
IExecution,IModule, ...), some of which may clash with different interfaces defined in other ERCs. For example, both ERC-6900 and ERC-7579 define aIModuleinterfaces (and they are not compatibles).Prefixing all interfaces declared in ERC-7579 with the name of the ERC avoid that kind of conflict.
This is common practice: for example, ERC-721 and ERC-1155 defined
ERC721TokenReceiverandERC1155TokenReceiverrespectivelly.A similar PR is targetting erc-6900.md with similar changes