Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove optional dependency with issues; update versions #350

Merged
merged 1 commit into from
Aug 21, 2023
Merged

Remove optional dependency with issues; update versions #350

merged 1 commit into from
Aug 21, 2023

Conversation

flcl42
Copy link
Contributor

@flcl42 flcl42 commented Aug 21, 2023 •
edited
Loading

Related to #239

  • Completely optional test project dependency coverlet.collector has issues reported similar to what the pipeline reports, let's remove it;
  • Upgrade test framework versions to the latest stable ones with hope it adds to stability.

@flcl42 flcl42 marked this pull request as ready for review August 21, 2023 07:27
@flcl42 flcl42 requested review from asn-d6 and jtraglia August 21, 2023 07:29
jtraglia
jtraglia reviewed Aug 21, 2023
View reviewed changes
Copy link
Member

@jtraglia jtraglia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good idea. LGTM 👍

@flcl42 flcl42 merged commit fa3c629 into main Aug 21, 2023
@jtraglia jtraglia deleted the update-packages-to-fix-pipeline branch August 31, 2023 21:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jtraglia jtraglia jtraglia left review comments

@asn-d6 asn-d6 Awaiting requested review from asn-d6

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@flcl42 @jtraglia