validator_service.py should live in this repo

[djrtwo]

validator_service.py is currently in a fork of the pyethapp repo here, but I propose it should be ported to this repo.

validator_service.py:

• directly depends on the implementation of the casper contract
• shares dependencies with the casper contract
• is automatically tested in this repo's build

Currently whenever we bump the version of vyper or pyethereum, change a public function name, or most other refactors, we have to update implementation and dependencies simultaneously in the other repo.

Proposed implementation

• port validator_service.py to either /daemon or a new directory /service
• update validator_service tests to run locally rather than across repos.
• remove validator_service.py from the pyethapp fork

[djrtwo]

@karlfloersch thoughts?

[karlfloersch]

@djrtwo I agree that if we reimplement validator_service.py using web3, it would totally make sense to move it here. Not sure exactly how to handle the old validator service though. Maybe we just build out the new web3 validator_service.py and then once that's done look into replacing the old one?

[djrtwo]

Works for me. I'll open a new issue around that.

…

On Monday, February 19, 2018, Karl Floersch ***@***.***> wrote: @djrtwo <https://github.com/djrtwo> I agree that if we reimplement validator_service.py using web3, it would totally make sense to move it here. Not sure exactly how to handle the old validator service though. Maybe we just build out the new web3 validator_service.py and then once that's done look into replacing the old one? — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#47 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/ABXf-4WRMqdNgYhFoQZnffyB0dRV__8Fks5tWY5EgaJpZM4SKgj5> .

[djrtwo]

Closing in favor of #48