Skip to content
This repository has been archived by the owner on May 16, 2022. It is now read-only.

Fix git identity #37

Open
ChrisChinchilla opened this issue May 20, 2020 · 4 comments
Open

Fix git identity #37

ChrisChinchilla opened this issue May 20, 2020 · 4 comments
Assignees
Labels
bug Something isn't working

Comments

@ChrisChinchilla
Copy link
Contributor

The "last edited by" field on wiki.js should reflect the last person who made a commit on Github, it currently doesn't.

@ChrisChinchilla ChrisChinchilla added the bug Something isn't working label May 20, 2020
@ChrisChinchilla
Copy link
Contributor Author

ChrisChinchilla commented May 20, 2020

Here's some examples…
If i use git locally, my username shows, if I make changes with my user account on the site it's undefined or anon.

Screenshot 2020-05-20 13 51 48

@bmann
Copy link

bmann commented May 20, 2020

WikiJS only supports a single commit identity by default, I believe.

@ChrisChinchilla
Copy link
Contributor Author

@bmann Hmm, maybe that will change 🤞

@wtf
Copy link
Member

wtf commented Jun 19, 2020

Thanks for reporting this @ChrisChinchilla. We should definitely try to display the latest contributor (whether the edit is on eth.wiki or github) under "Last edited by". I believe the author name is correctly displayed when edits go from eth.wiki to github.com/ethereum/eth-wiki, so the issue is only for github -> eth.wiki.

Please feel free to add more issues needed for the git integration to work seamlessly and assign me to them.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants