From 2a8edec0be125653218d0c8e5217146234c2d3c9 Mon Sep 17 00:00:00 2001 From: Corwin Smith Date: Thu, 9 Jun 2022 12:16:03 -0600 Subject: [PATCH 01/10] wallet listing policy --- .../contributing/adding-wallet/index.md | 72 +++++++++++++++++++ src/content/contributing/index.md | 1 + 2 files changed, 73 insertions(+) create mode 100644 src/content/contributing/adding-wallet/index.md diff --git a/src/content/contributing/adding-wallet/index.md b/src/content/contributing/adding-wallet/index.md new file mode 100644 index 00000000000..afc8de81617 --- /dev/null +++ b/src/content/contributing/adding-wallet/index.md @@ -0,0 +1,72 @@ +--- +title: Adding wallets +description: The policy we use when adding a wallet to ethereum.org +lang: en +sidebar: true +--- + +# Adding wallets {#adding-wallets} + +We want to make sure we show a variety of wallets covering the feature rich landscape of wallets so that users can navigate Ethereum in a confident manner. + +Anyone is free to suggest adding a wallet on ethereum.org. If there's a wallet that we have missed, please suggest it! + +Anyone is free to suggest a new wallet. Wallets are currently listed on: + +- [ethereum.org/wallets/find-wallet](/wallets/find-wallet/) + +Wallets are rapidly changing in Ethereum. We've tried to create a fair framework for consideration on ethereum.org but the listing criteria will change and evolve over time. + +## The decision framework {#the-decision-framework} + +### Criteria for inclusion: the must-haves {#the-must-haves} + +- **A security-tested product** - whether through audit, an internal security team, open sourced coded, or some other method, your wallets security must be reliable. This reduces the risk to our users and shows us that you take security seriously. +- **A wallet that has been “live” for over 6 months OR released by a group with a reputable track record** - this is another indication of security. 6 months is a good time frame for critical bugs and exploitations to have been found. We ask 6 months to help filter our forks that are quickly abandoned as projects. +- **Worked on by an active team** - this helps to ensure quality and that a user will get support for their queries. +- **Honest and accurate listing information** - it is expected that any suggesting listings from projects come with honest and accurate information. Products that falsify listing information, such as declaring your product is “open source” when it is not, will be removed. +- **Point of contact** - A point of contact for the wallet will greatly help us get accurate information when changes are made. This will keep updating ethereum.org manageable when gathering future information. + +### Other criteria: the nice-to-haves {#the-nice-to-haves} + +- **Globally accessible** - your wallet doesn’t have geographic limitations or KYC requirements that exclude certain people from accessing your service. +- **Available in multiple languages** - your wallet is translated into multiple languages allowing users around the world to access it. +- **Open source** - your whole project’s codebase (not just modules) should be accessible and you should accept PR’s from the wider community. +- **Non-custodial** - users control their funds. If your product disappears, users can still access and move their funds. +- **Hardware wallet support** - users can connect their hardware wallet to sign transactions. +- **WalletConnect** - users can connect to dapps using WalletConnect. +- **Importing Ethereum RPC endpoints** - users can import node RPC data, allowing them to connect to a node of their choice, or other EVM compatible networks. +- **NFTs** - users are able to view and interact with their NFT’s in the wallet. +- **Connect to Ethereum applications** - users are able to connect to and use Ethereum applications. +- **Staking** - users are able to stake directly through the wallet. +- **Swaps** - users are able to swap tokens through the wallet. +- **Multichain networks** - your wallet supports users accessing multiple blockchain networks by default. +- **Customize gas fees** - your wallet allows users to customize their transaction gas fees (base fee, priority fee, max fee) +- **ENS support** - your wallet allows users to send transactions to ENS names. +- **ERC-20 support** - your wallet allows users to import ERC-20 token contracts, or automatically queries and displays ERC-20 tokens. +- **EIP-1559 (type 2) transactions** - your wallet supports EIP-1559 (type 2) transactions. +- **Buy crypto** - your wallet supports users directly purchasing and onboarding to crypto. +- **Withdraw crypto** - your wallet supports users withdrawing directly to card or a bank account. +- **Multisig** - your wallet supports multiple signatures to sign a transaction. +- **Social recovery** - your wallet supports guardians and a user can recover their wallet if they lose their seed phrase using these guardians. +- **Dedicated support team** - your wallet has a dedicated support team where users can go to when experiencing issues. +- **Educational resources/documentation** - your product should have a well-designed onboarding experience to help and educate users. Or evidence of how-to content like articles or videos. + +## Adding a wallet {#adding-a-wallet} + +If you want to add a wallet to ethereum.org, create an issue on GitHub. + + + Create an issue + + +## Maintenance {#maintenance} + +As is the fluid nature of Ethereum, teams and products come and go and innovation happens daily, so we'll undertake routine checks of our content to: + +- ensure that all wallets and dapps listed still fulfil our criteria +- verify there aren't products that have been suggested that meet more of our criteria than the ones currently listed + +## Terms of use {#terms-of-use} + +Please also refer to our [terms of use](/terms-of-use/). Information on ethereum.org is provided solely for general information purposes. diff --git a/src/content/contributing/index.md b/src/content/contributing/index.md index ad483c20eb8..21d8c999e05 100644 --- a/src/content/contributing/index.md +++ b/src/content/contributing/index.md @@ -39,6 +39,7 @@ The ethereum.org website, like Ethereum more broadly, is an open-source project. - [Add a layer 2](/contributing/adding-layer-2) _- Add a layer 2 to a relevant page_ - [Add a staking product or service](/contributing/adding-staking-product/) - _Add a project that helps facilitate solo staking, pooled staking, or staking as a service_ +- [Add a wallet](/contributing/adding-wallet/) _- Add a wallet for the [find wallets page](/wallets/find-wallet/)._ _Any questions?_ 🤔 Reach out on our [Discord server](https://discord.gg/CetY6Y4) From 23f197d1a16663b79292d5ebac71ec5fbe167119 Mon Sep 17 00:00:00 2001 From: Corwin Smith Date: Tue, 14 Jun 2022 00:02:03 -0600 Subject: [PATCH 02/10] Update src/content/contributing/adding-wallet/index.md Co-authored-by: Luka Kropec <37338979+lukassim@users.noreply.github.com> --- src/content/contributing/adding-wallet/index.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/content/contributing/adding-wallet/index.md b/src/content/contributing/adding-wallet/index.md index afc8de81617..86f1aa8f9f3 100644 --- a/src/content/contributing/adding-wallet/index.md +++ b/src/content/contributing/adding-wallet/index.md @@ -7,7 +7,7 @@ sidebar: true # Adding wallets {#adding-wallets} -We want to make sure we show a variety of wallets covering the feature rich landscape of wallets so that users can navigate Ethereum in a confident manner. +We want to make sure we show a variety of wallets covering the feature-rich landscape of wallets so that users can navigate Ethereum in a confident manner. Anyone is free to suggest adding a wallet on ethereum.org. If there's a wallet that we have missed, please suggest it! From 66b374341ff3d7fc68ee661f8822a87f7cf85a32 Mon Sep 17 00:00:00 2001 From: Corwin Smith Date: Tue, 14 Jun 2022 00:02:12 -0600 Subject: [PATCH 03/10] Update src/content/contributing/adding-wallet/index.md Co-authored-by: Luka Kropec <37338979+lukassim@users.noreply.github.com> --- src/content/contributing/adding-wallet/index.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/content/contributing/adding-wallet/index.md b/src/content/contributing/adding-wallet/index.md index 86f1aa8f9f3..352e142f25e 100644 --- a/src/content/contributing/adding-wallet/index.md +++ b/src/content/contributing/adding-wallet/index.md @@ -22,7 +22,7 @@ Wallets are rapidly changing in Ethereum. We've tried to create a fair framework ### Criteria for inclusion: the must-haves {#the-must-haves} - **A security-tested product** - whether through audit, an internal security team, open sourced coded, or some other method, your wallets security must be reliable. This reduces the risk to our users and shows us that you take security seriously. -- **A wallet that has been “live” for over 6 months OR released by a group with a reputable track record** - this is another indication of security. 6 months is a good time frame for critical bugs and exploitations to have been found. We ask 6 months to help filter our forks that are quickly abandoned as projects. +- **A wallet that has been “live” for over 6 months OR released by a group with a reputable track record** - this is another indication of security. 6 months is a good time frame for critical bugs and exploitations to have been found. We ask 6 months to help filter out forks that are quickly abandoned as projects. - **Worked on by an active team** - this helps to ensure quality and that a user will get support for their queries. - **Honest and accurate listing information** - it is expected that any suggesting listings from projects come with honest and accurate information. Products that falsify listing information, such as declaring your product is “open source” when it is not, will be removed. - **Point of contact** - A point of contact for the wallet will greatly help us get accurate information when changes are made. This will keep updating ethereum.org manageable when gathering future information. From ea7912d2117adfedb72451775533b5ed1f022522 Mon Sep 17 00:00:00 2001 From: Corwin Smith Date: Tue, 14 Jun 2022 00:02:23 -0600 Subject: [PATCH 04/10] Update src/content/contributing/adding-wallet/index.md Co-authored-by: Luka Kropec <37338979+lukassim@users.noreply.github.com> --- src/content/contributing/adding-wallet/index.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/content/contributing/adding-wallet/index.md b/src/content/contributing/adding-wallet/index.md index 352e142f25e..fdd77cf8beb 100644 --- a/src/content/contributing/adding-wallet/index.md +++ b/src/content/contributing/adding-wallet/index.md @@ -24,7 +24,7 @@ Wallets are rapidly changing in Ethereum. We've tried to create a fair framework - **A security-tested product** - whether through audit, an internal security team, open sourced coded, or some other method, your wallets security must be reliable. This reduces the risk to our users and shows us that you take security seriously. - **A wallet that has been “live” for over 6 months OR released by a group with a reputable track record** - this is another indication of security. 6 months is a good time frame for critical bugs and exploitations to have been found. We ask 6 months to help filter out forks that are quickly abandoned as projects. - **Worked on by an active team** - this helps to ensure quality and that a user will get support for their queries. -- **Honest and accurate listing information** - it is expected that any suggesting listings from projects come with honest and accurate information. Products that falsify listing information, such as declaring your product is “open source” when it is not, will be removed. +- **Honest and accurate listing information** - it is expected that any suggested listings from projects come with honest and accurate information. Products that falsify listing information, such as declaring your product is “open source” when it is not, will be removed. - **Point of contact** - A point of contact for the wallet will greatly help us get accurate information when changes are made. This will keep updating ethereum.org manageable when gathering future information. ### Other criteria: the nice-to-haves {#the-nice-to-haves} From 5989017031691854eec05fbc7cbdb0073dfe31f7 Mon Sep 17 00:00:00 2001 From: Corwin Smith Date: Tue, 14 Jun 2022 00:02:28 -0600 Subject: [PATCH 05/10] Update src/content/contributing/adding-wallet/index.md Co-authored-by: Luka Kropec <37338979+lukassim@users.noreply.github.com> --- src/content/contributing/adding-wallet/index.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/content/contributing/adding-wallet/index.md b/src/content/contributing/adding-wallet/index.md index fdd77cf8beb..8f017d8aba0 100644 --- a/src/content/contributing/adding-wallet/index.md +++ b/src/content/contributing/adding-wallet/index.md @@ -36,7 +36,7 @@ Wallets are rapidly changing in Ethereum. We've tried to create a fair framework - **Hardware wallet support** - users can connect their hardware wallet to sign transactions. - **WalletConnect** - users can connect to dapps using WalletConnect. - **Importing Ethereum RPC endpoints** - users can import node RPC data, allowing them to connect to a node of their choice, or other EVM compatible networks. -- **NFTs** - users are able to view and interact with their NFT’s in the wallet. +- **NFTs** - users are able to view and interact with their NFTs in the wallet. - **Connect to Ethereum applications** - users are able to connect to and use Ethereum applications. - **Staking** - users are able to stake directly through the wallet. - **Swaps** - users are able to swap tokens through the wallet. From 4b04938e2acc32c6072ef3b3e258b67def50b57b Mon Sep 17 00:00:00 2001 From: Corwin Smith Date: Tue, 14 Jun 2022 00:02:34 -0600 Subject: [PATCH 06/10] Update src/content/contributing/adding-wallet/index.md Co-authored-by: Luka Kropec <37338979+lukassim@users.noreply.github.com> --- src/content/contributing/adding-wallet/index.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/content/contributing/adding-wallet/index.md b/src/content/contributing/adding-wallet/index.md index 8f017d8aba0..b60af24a255 100644 --- a/src/content/contributing/adding-wallet/index.md +++ b/src/content/contributing/adding-wallet/index.md @@ -41,7 +41,7 @@ Wallets are rapidly changing in Ethereum. We've tried to create a fair framework - **Staking** - users are able to stake directly through the wallet. - **Swaps** - users are able to swap tokens through the wallet. - **Multichain networks** - your wallet supports users accessing multiple blockchain networks by default. -- **Customize gas fees** - your wallet allows users to customize their transaction gas fees (base fee, priority fee, max fee) +- **Customize gas fees** - your wallet allows users to customize their transaction gas fees (base fee, priority fee, max fee). - **ENS support** - your wallet allows users to send transactions to ENS names. - **ERC-20 support** - your wallet allows users to import ERC-20 token contracts, or automatically queries and displays ERC-20 tokens. - **EIP-1559 (type 2) transactions** - your wallet supports EIP-1559 (type 2) transactions. From 3e4d71972e2c0641fd68e04239a78a39a160a37f Mon Sep 17 00:00:00 2001 From: Corwin Smith Date: Tue, 14 Jun 2022 00:02:41 -0600 Subject: [PATCH 07/10] Update src/content/contributing/adding-wallet/index.md Co-authored-by: Luka Kropec <37338979+lukassim@users.noreply.github.com> --- src/content/contributing/adding-wallet/index.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/content/contributing/adding-wallet/index.md b/src/content/contributing/adding-wallet/index.md index b60af24a255..58ab24bdcac 100644 --- a/src/content/contributing/adding-wallet/index.md +++ b/src/content/contributing/adding-wallet/index.md @@ -21,7 +21,7 @@ Wallets are rapidly changing in Ethereum. We've tried to create a fair framework ### Criteria for inclusion: the must-haves {#the-must-haves} -- **A security-tested product** - whether through audit, an internal security team, open sourced coded, or some other method, your wallets security must be reliable. This reduces the risk to our users and shows us that you take security seriously. +- **A security-tested product** - whether through audit, an internal security team, open sourced coded, or some other method, your wallet's security must be reliable. This reduces the risk to our users and shows us that you take security seriously. - **A wallet that has been “live” for over 6 months OR released by a group with a reputable track record** - this is another indication of security. 6 months is a good time frame for critical bugs and exploitations to have been found. We ask 6 months to help filter out forks that are quickly abandoned as projects. - **Worked on by an active team** - this helps to ensure quality and that a user will get support for their queries. - **Honest and accurate listing information** - it is expected that any suggested listings from projects come with honest and accurate information. Products that falsify listing information, such as declaring your product is “open source” when it is not, will be removed. From c829132e8d12347e316c14c6685691ca6c7d63f5 Mon Sep 17 00:00:00 2001 From: Corwin Smith Date: Tue, 14 Jun 2022 14:13:14 -0600 Subject: [PATCH 08/10] change requests --- src/content/contributing/adding-wallet/index.md | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/src/content/contributing/adding-wallet/index.md b/src/content/contributing/adding-wallet/index.md index 58ab24bdcac..a05ab8c7ec9 100644 --- a/src/content/contributing/adding-wallet/index.md +++ b/src/content/contributing/adding-wallet/index.md @@ -13,7 +13,9 @@ Anyone is free to suggest adding a wallet on ethereum.org. If there's a wallet t Anyone is free to suggest a new wallet. Wallets are currently listed on: -- [ethereum.org/wallets/find-wallet](/wallets/find-wallet/) +- [ethereum.org/wallets/find-wallet/](/wallets/find-wallet/) +- [ethereum.org/wallets/](/wallets/) +- [ethereum.org/get-eth/](/get-eth/) Wallets are rapidly changing in Ethereum. We've tried to create a fair framework for consideration on ethereum.org but the listing criteria will change and evolve over time. @@ -56,7 +58,7 @@ Wallets are rapidly changing in Ethereum. We've tried to create a fair framework If you want to add a wallet to ethereum.org, create an issue on GitHub. - + Create an issue @@ -67,6 +69,8 @@ As is the fluid nature of Ethereum, teams and products come and go and innovatio - ensure that all wallets and dapps listed still fulfil our criteria - verify there aren't products that have been suggested that meet more of our criteria than the ones currently listed +Ethereum.org is maintained by the open source community & we rely on the community to help keep this up to date. If you notice any information wallets that needs to be updated, please [open an issue](https://github.com/ethereum/ethereum-org-website/blob/dev/.github/ISSUE_TEMPLATE/suggest_wallet.yaml) or [pull request](https://github.com/ethereum/ethereum-org-website/pulls)! + ## Terms of use {#terms-of-use} Please also refer to our [terms of use](/terms-of-use/). Information on ethereum.org is provided solely for general information purposes. From 3dc8ac747c63b8dd2b4c196d95d113a9d2eb2e0c Mon Sep 17 00:00:00 2001 From: Corwin Smith Date: Tue, 14 Jun 2022 14:33:55 -0600 Subject: [PATCH 09/10] fix sentence --- src/content/contributing/adding-wallet/index.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/content/contributing/adding-wallet/index.md b/src/content/contributing/adding-wallet/index.md index a05ab8c7ec9..48e156a5880 100644 --- a/src/content/contributing/adding-wallet/index.md +++ b/src/content/contributing/adding-wallet/index.md @@ -69,7 +69,7 @@ As is the fluid nature of Ethereum, teams and products come and go and innovatio - ensure that all wallets and dapps listed still fulfil our criteria - verify there aren't products that have been suggested that meet more of our criteria than the ones currently listed -Ethereum.org is maintained by the open source community & we rely on the community to help keep this up to date. If you notice any information wallets that needs to be updated, please [open an issue](https://github.com/ethereum/ethereum-org-website/blob/dev/.github/ISSUE_TEMPLATE/suggest_wallet.yaml) or [pull request](https://github.com/ethereum/ethereum-org-website/pulls)! +Ethereum.org is maintained by the open source community & we rely on the community to help keep this up to date. If you notice any information about listed wallets that needs to be updated, please [open an issue](https://github.com/ethereum/ethereum-org-website/blob/dev/.github/ISSUE_TEMPLATE/suggest_wallet.yaml) or [pull request](https://github.com/ethereum/ethereum-org-website/pulls)! ## Terms of use {#terms-of-use} From 712199416768659098c5d462bdf501c325099ddb Mon Sep 17 00:00:00 2001 From: Paul Wackerow <54227730+wackerow@users.noreply.github.com> Date: Thu, 16 Jun 2022 17:16:06 -0700 Subject: [PATCH 10/10] Update src/content/contributing/adding-wallet/index.md --- src/content/contributing/adding-wallet/index.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/content/contributing/adding-wallet/index.md b/src/content/contributing/adding-wallet/index.md index 48e156a5880..bdc21e965d6 100644 --- a/src/content/contributing/adding-wallet/index.md +++ b/src/content/contributing/adding-wallet/index.md @@ -24,7 +24,7 @@ Wallets are rapidly changing in Ethereum. We've tried to create a fair framework ### Criteria for inclusion: the must-haves {#the-must-haves} - **A security-tested product** - whether through audit, an internal security team, open sourced coded, or some other method, your wallet's security must be reliable. This reduces the risk to our users and shows us that you take security seriously. -- **A wallet that has been “live” for over 6 months OR released by a group with a reputable track record** - this is another indication of security. 6 months is a good time frame for critical bugs and exploitations to have been found. We ask 6 months to help filter out forks that are quickly abandoned as projects. +- **A wallet that has been “live” for over six months OR released by a group with a reputable track record** - this is another indication of security. Six months is a good time frame for critical bugs and exploitations to have been found. We ask six months to help filter out forks that are quickly abandoned as projects. - **Worked on by an active team** - this helps to ensure quality and that a user will get support for their queries. - **Honest and accurate listing information** - it is expected that any suggested listings from projects come with honest and accurate information. Products that falsify listing information, such as declaring your product is “open source” when it is not, will be removed. - **Point of contact** - A point of contact for the wallet will greatly help us get accurate information when changes are made. This will keep updating ethereum.org manageable when gathering future information.