Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add WallETH #3058

Closed
ligi opened this issue May 16, 2021 · 7 comments · Fixed by #3160
Closed

add WallETH #3058

ligi opened this issue May 16, 2021 · 7 comments · Fixed by #3160
Labels
content 🖋️ This involves copy additions or edits feature ✨ This is enhancing something existing or creating something new

Comments

@ligi
Copy link
Member

ligi commented May 16, 2021

Is your wallet globally accessible?

Yes

Is your wallet custodial, non-custodial, or a hardware wallet?

non-custodial and supports hardware wallets (TREZOR, KeepKey, KeyCard)

Please describe the measures taken to ensure the wallet's security and provide documentation wherever possible

Does the wallet have fiat on-ramps?

no (does not belong into a Wallet IMHO) - can be done outside the wallet

Does the wallet allow users to explore dapps?

Yes you can explore WalletConnect enabled dapps

Does the wallet have integrated defi/financial tools?

no (does not belong into a Wallet IMHO) - you can access these tools via WalletConnect

Can a user withdraw to their card?

no (does not belong into a Wallet IMHO)

Does the wallet offer limits protection?

not yet

Does the wallet allow high-volume purchases?

yes - e.g. via uniswap via WalletConnect

Does the wallet have an integrated token swap?

no (does not belong into a Wallet IMHO) - can be done via WalletConnect

Is the wallet a multi-signature wallet?

not yet

Wallet title

WallETH

Wallet description

100% open source (GPLv3) and native Android Ethereum Wallet for your service since 2017. Connect to your favorite Ethereum Applications via WalletConnect and use it directly with hardware wallets like the TREZOR or KeepKey via USB or the KeyCard via NFC.

Wallet logo

walleth_icon

Background colour for brand logo

0xFFFFFF

Link

https://walleth.org

@ligi ligi added content 🖋️ This involves copy additions or edits feature ✨ This is enhancing something existing or creating something new labels May 16, 2021
@ryancreatescopy
Copy link
Contributor

Thanks @ligi@wackerow let's discuss this and get a PR up when we get some capacity.

@ligi if you have time feel free to raise a PR as this may be faster at the moment with our current commitments.

@ligi
Copy link
Member Author

ligi commented May 25, 2021

Thanks for considering. I would see #2730 as a blocker for a PR - can you please reopen the issue? Unfortunately I cannot do this.

@ryancreatescopy
Copy link
Contributor

ryancreatescopy commented May 26, 2021

Not sure it's necessarily a blocker, we can always list the wallet before changing the format, but I've reopened nonetheless. As a heads up, I can't promise we'll have time to work on this for a while, however we are expanding our dev team very shortly so fingers crossed we can address this soon.

@ligi
Copy link
Member Author

ligi commented May 26, 2021

@ryancreatescopy thanks - It's just a blocker if I would need to open the PR - really do not want to touch this dirty CSV ;-)

@minimalsm
Copy link
Contributor

@ligi added a PR to add this. Can you confirm what I have below is correct:

{
"id": "walleth",
"name": "WallETH",
"url": "https://walleth.org",
"brand_color": "#FFF",
"has_mobile": true,
"has_desktop": false,
"has_web": false,
"has_hardware": false,
"has_card_deposits": false,
"has_explore_dapps": true,
"has_defi_integrations": false,
"has_bank_withdrawals": false,
"has_limits_protection": false,
"has_high_volume_purchases": true,
"has_multisig": false,
"has_dex_integrations": false
}

@ligi
Copy link
Member Author

ligi commented May 29, 2021

thanks! Looks all good - just change "has_high_volume_purchases": true, to "has_high_volume_purchases": false, please.

@minimalsm
Copy link
Contributor

thanks! Looks all good - just change "has_high_volume_purchases": true, to "has_high_volume_purchases": false, please.

Done :]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
content 🖋️ This involves copy additions or edits feature ✨ This is enhancing something existing or creating something new
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants