Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update gas docs to post-London/EIP-1559 info only #5660

Closed
samajammin opened this issue Mar 12, 2022 · 5 comments · Fixed by #12008
Closed

Update gas docs to post-London/EIP-1559 info only #5660

samajammin opened this issue Mar 12, 2022 · 5 comments · Fixed by #12008
Labels
content 🖋️ This involves copy additions or edits feature ✨ This is enhancing something existing or creating something new good first issue Good item to try if you're new to contributing

Comments

@samajammin
Copy link
Member

samajammin commented Mar 12, 2022

Is your feature request related to a problem? Please describe.

Last year we created a bunch of updates around the London upgrade / EIP-1559: #3022 #3521

I'm wondering how long we should frame the content on the gas page as "Prior to the London upgrade" & "After the London upgrade".

  • Should we update that page to reflect the current state of Ethereum (i.e. post-London)? If so, when?
  • Should we continue to provide info on the historical structure of the gas market? Should ethereum.org provide an archive of sorts for this information, or can other places (e.g. https://ethdocs.org/) serve this purpose? Is providing historical references even valuable, or does it risk creating confusion in the ecosystem?

Describe the solution you'd like

For now I lean towards the stance that ethereum.org should focus on keeping content up to date with the current state of Ethereum. That means updating this gas page (& all content) to explain how Ethereum works now vs. how Ethereum has worked in the past.

Describe alternatives you've considered

As mentioned above, I'm open to input on how we may also provide an archive of how Ethereum once worked.

Additional context

This also relates to #3908

Want to contribute?

We love contributions from the Ethereum community! Please comment on an issue if you have input on the proposed updates or if you're interested in helping out with a PR.

@samajammin samajammin added feature ✨ This is enhancing something existing or creating something new content 🖋️ This involves copy additions or edits proposal 🤔 This is a proposal labels Mar 12, 2022
@corwintines
Copy link
Member

I think we should update the gas page to just portray the current state of Ethereum now that London has been out for quite a few months, and move some of the historical gas information to the /history/ page. We could probably overhaul the history page to accommodate for that change if we are going to add this information though. I do think there is some value showing the history of big changes like this though, and we have that page already. Seems like a good fit to me.

@github-actions
Copy link
Contributor

github-actions bot commented May 6, 2022

This issue is stale because it has been open 45 days with no activity.

@github-actions github-actions bot added the Status: Stale This issue is stale because it has been open 30 days with no activity. label May 6, 2022
@corwintines corwintines added 30web3 and removed Status: Stale This issue is stale because it has been open 30 days with no activity. labels Jan 23, 2023
@corwintines corwintines removed the 30web3 label May 8, 2023
@wackerow
Copy link
Member

wackerow commented Jan 8, 2024

Agree... this has been sitting for a while, and all the more reason I don't think we need that historical context directly in the dev docs anymore. I would recommend updating this page to describe the current state of Ethereum, and remove superfluous comments about the London upgrade.

@wackerow wackerow added the good first issue Good item to try if you're new to contributing label Jan 8, 2024
@corwintines
Copy link
Member

For who wants to pick this up

We should remove the What was the London Upgrade / EIP-1559? section from https://github.com/ethereum/ethereum-org-website/blob/dev/src/content/developers/docs/gas/index.md#what-was-the-london-upgrade--eip-1559-what-was-the-london-upgrade-eip-1559

This can be added to the London upgrade section on the history page https://github.com/ethereum/ethereum-org-website/blob/dev/src/content/developers/docs/gas/index.md#what-was-the-london-upgrade--eip-1559-what-was-the-london-upgrade-eip-1559

I think we can use an expandable card for this information (can reference use of this in that upgrade).

@corwintines corwintines removed the proposal 🤔 This is a proposal label Jan 8, 2024
@Crosstons
Copy link
Contributor

Crosstons commented Jan 22, 2024

image
@corwintines @wackerow
Just to confirm the What was the London Upgrade /EIP-1559? expandable card is to be added just below the London EIPS expandable card? am I right?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
content 🖋️ This involves copy additions or edits feature ✨ This is enhancing something existing or creating something new good first issue Good item to try if you're new to contributing
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants