Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update all wallet data with new issue form questions #6536

Closed
24 of 40 tasks
corwintines opened this issue Jun 1, 2022 · 20 comments
Closed
24 of 40 tasks

Update all wallet data with new issue form questions #6536

corwintines opened this issue Jun 1, 2022 · 20 comments
Labels
feature ✨ This is enhancing something existing or creating something new good first issue Good item to try if you're new to contributing help wanted Extra attention is needed or someone is needed to help high priority This has a high priority

Comments

@corwintines
Copy link
Member

corwintines commented Jun 1, 2022

Is your feature request related to a problem? Please describe.
As part of the find-wallet page revamp (#6274) we have updated the issue template form for wallets (https://github.com/ethereum/ethereum-org-website/issues/new?assignees=&labels=wallet+%3Apurse%3A&template=suggest_wallet.yaml&title=Suggest+a+wallet). This new issue template expands the data we gather on features that wallets provide. With the release of this, our wallet data is now out of date for wallets.

Describe the solution you'd like

Fill out the issue template (i.e. create an issue) for each of the wallets we currently list on ethereum.org to make sure we have up to date data for the release of the new find-wallets page.

Additional context

We plan to ship the updated wallet features by end of Q2, whether or not we have all the wallet data, so please help us collect this information ASAP if you'd like a wallet to remain listed! If we don't have the data for a given wallet, it will be filtered out from any new feature filters.

Wallets that need to be filled out:

Want to contribute?
We would love and appreciate any support in gathering this information. If you would like to contribute, please claim a wallet to fill out and link back to this issue so we can track progress :)

@corwintines corwintines added the feature ✨ This is enhancing something existing or creating something new label Jun 1, 2022
@samajammin samajammin added help wanted Extra attention is needed or someone is needed to help high priority This has a high priority good first issue Good item to try if you're new to contributing labels Jun 7, 2022
@samajammin samajammin pinned this issue Jun 7, 2022
@Mousticke
Copy link
Contributor

Mousticke commented Jun 7, 2022

Opened a draft issue for Ledger Nano X : #6598
I will complete no mandatory fields as soon as I get some official information (audit security for example)

@sambacha
Copy link

sambacha commented Jun 7, 2022

Fortmatic is now Magic

@sambacha
Copy link

sambacha commented Jun 7, 2022

Metamask has Metamask mobile, which is not the same as Metamask (desktop) they do not have the same features. As does Argent wallet with Android and iOS: they do not have feature parity (yet?)

The issue template leaves this as ambiguous when listing supported platforms

@chlolands
Copy link

Can you please add Tally Ho?

[https://tally.cash/]
[https://github.com/tallycash/extension]

@floating
Copy link

floating commented Jun 7, 2022

Please add Frame: #6601

Thank you! 🙏

@Ivshti
Copy link

Ivshti commented Jun 8, 2022

Please add Ambire: #6612 🙏

Ambire is a human-friendly smart wallet for Web3, supporting many next-gen features such as advanced transaction visualization and batching, paying gas in stablecoins, non-custodial email/password authentication and others.

@Mousticke
Copy link
Contributor

Ledger Nano X : #6598 Finished

@rolodexter
Copy link
Contributor

where is the criteria for how you decide on whether or not to include a wallet on the list

@rolodexter
Copy link
Contributor

image
for onboarding purposes would it be useful to list some stats on the profile square like userbasesizecategory

for friends that i try to onboard i think they'd like to be able to filter wallets by mass market platform compatibility like coinbase opensea

@Dadybayo
Copy link
Contributor

Dadybayo commented Jun 23, 2022

Unstoppable
#6796

@arielman87
Copy link

🙏🏼Please review and add Sequence Issue: #7056 💜
Sequence Wallet Contact: @PhABC

@jack-cryptocom
Copy link

Please review and consider to add #6155 (Crypto.com Defi Wallet), thanks!

@corwintines
Copy link
Member Author

Update: continuing to review incoming issues. Will close this out soon as we have most of these wallets added now. Part of doing this was to filter out wallets, and ones that havent submitted will not be featured anymore.

@Dadybayo
Copy link
Contributor

Dadybayo commented Aug 5, 2022

Update: continuing to review incoming issues. Will close this out soon as we have most of these wallets added now. Part of doing this was to filter out wallets, and ones that havent submitted will not be featured anymore.

#6796 (comment)

@Thomas772-nyben
Copy link

Getting to find this team was a blessing to me during my divorce process. My ex took nearly everything from me including my kids, however with the help of this professional Investigators who got into his phone and provided me with conversations and deleted pictures, I was able to prove that he was toxic and abusive. I won the children custody.
WWW. HACKMART.ORG

@samajammin
Copy link
Member

@corwintines think we should close this out? I think if anyone wants to add any remaining wallets, they can create a dedicated issue with the wallet info:
https://github.com/ethereum/ethereum-org-website/issues/new?assignees=&labels=wallet+%3Apurse%3A&template=suggest_wallet.yaml&title=Suggest+a+wallet

@corwintines
Copy link
Member Author

Yes this is ready to close.

@samajammin samajammin unpinned this issue Oct 25, 2022
@Euronumero231
Copy link

Euronumero231 commented May 26, 2023

10/10 Amazing!!!
This is by far one of the more enjoyable service I have received from this website recommended, their customer service is outstanding, you can simply contact them their website WWW. NITROCRACKHUB . COM), they gave me a very detailed and simple instruction on how possible it was for me to see all activities of my spouse right from my phone, highly recommended, their customer service is outstanding, you can simply contact them their website WWW. NITROCRACKHUB . COM) as well ( that’s where I got the most sense of security was being able to talk to them on discord to confirm everything ) thank you very much for a smooth transaction!! Have a wonderful day!!! - (NITROCRACKHUB@GMAIL .COM)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature ✨ This is enhancing something existing or creating something new good first issue Good item to try if you're new to contributing help wanted Extra attention is needed or someone is needed to help high priority This has a high priority
Projects
None yet
Development

No branches or pull requests

16 participants