You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Here size is required but set with a default value in the functional components. Other components require the Emoji component and have to set the size because of the interface.
We should replace the required props as an optional props.
Expected behavior
We expect this interface in src/components/Emoji.tsx
importing a svg in React cause the typescript compiler to raise an error
"Could not find module...". svg are not React component so we have to
define a module that export it as a React component
fix(emoji): size should be optional
Refs: ethereum#6382ethereum#6626
Describe the bug
This is purely coding style issue.
The
Emoji
component has asize
props with a default valuewith a defined interface
IProps
Here
size
is required but set with a default value in the functional components. Other components require theEmoji
component and have to set thesize
because of the interface.We should replace the required props as an optional props.
Expected behavior
We expect this interface in
src/components/Emoji.tsx
Additional context
Part of the Typescript rollout: #6392
Emoji PR for the migration: #6540
Want to contribute?
You can assign me this issue if you want.
The text was updated successfully, but these errors were encountered: