Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Configure new /find-wallet page for translations #7373

Closed
samajammin opened this issue Aug 10, 2022 · 4 comments
Closed

Configure new /find-wallet page for translations #7373

samajammin opened this issue Aug 10, 2022 · 4 comments
Assignees
Labels
feature ✨ This is enhancing something existing or creating something new Status: Stale This issue is stale because it has been open 30 days with no activity.

Comments

@samajammin
Copy link
Member

Is your feature request related to a problem? Please describe.

As a result of #6274, the page is no longer configured for translations. As part the "wallet upgrades" epic (#7250), we should do this as one of the last steps (i.e. we should make page updates/improvements BEFORE configuring translations).

Describe the solution you'd like

Configure the file(s) for translation.

@samajammin samajammin added the feature ✨ This is enhancing something existing or creating something new label Aug 10, 2022
@samajammin
Copy link
Member Author

@corwintines calling attention to this file to make sure we don't miss it - we'll want to translate these strings:
https://github.com/ethereum/ethereum-org-website/blob/dev/src/data/wallets/wallet-filters.ts

@corwintines
Copy link
Member

Thanks for making this @samajammin! I think we should be able to do this soon. There are a few changes we should look at for copy from user testing feedback, and want to do a bit of refactoring on some smelly code to clean it up first.

@github-actions
Copy link
Contributor

This issue is stale because it has been open 45 days with no activity.

@github-actions github-actions bot added the Status: Stale This issue is stale because it has been open 30 days with no activity. label Sep 24, 2022
@corwintines
Copy link
Member

This has been completed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature ✨ This is enhancing something existing or creating something new Status: Stale This issue is stale because it has been open 30 days with no activity.
Projects
None yet
Development

No branches or pull requests

2 participants