Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Links in JSON are unstyled #8547

Closed
minimalsm opened this issue Nov 9, 2022 · 1 comment
Closed

Links in JSON are unstyled #8547

minimalsm opened this issue Nov 9, 2022 · 1 comment
Labels
a11y ♿️ This issue relates to accessibility bug 🐛 Something isn't working high priority This has a high priority

Comments

@minimalsm
Copy link
Contributor

minimalsm commented Nov 9, 2022

Describe the bug

The links that we create through HTML embedded in JSON are not getting styled. Other tags (e.g. bold, italics) seem to be working fine.

Some pages this effects:
https://ethereum.org/en/run-a-node/
https://ethereum.org/en/staking/
https://ethereum.org/en/layer-2/
https://ethereum.org/en/what-is-ethereum/

To reproduce

  1. Go to 'https://ethereum.org/en/layer-2/'
  2. Search 'blockchain trilemma'
  3. Hover over text
  4. See error

Expected behavior

All links should be styled as per our theme

Screenshots

Screenshot 2022-11-09 at 11 46 11

Additional context

First deploy I see this bug is 6.1.0 (#7766); it doesn't look to be present in 6.0.0 (#7658), which is when we started migrating to Chakra UI.

@minimalsm minimalsm added bug 🐛 Something isn't working high priority This has a high priority a11y ♿️ This issue relates to accessibility labels Nov 9, 2022
@TylerAPfledderer
Copy link
Contributor

TylerAPfledderer commented Nov 9, 2022

@minimalsm looks like the styling got lost when moving GlobalStyle.tsx to the Chakra theme in styles.ts. There may be a few others that were missed as well?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
a11y ♿️ This issue relates to accessibility bug 🐛 Something isn't working high priority This has a high priority
Projects
None yet
Development

No branches or pull requests

2 participants