Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change the hero image to a new illustration on the wallet page #9940

Closed
2 tasks
nloureiro opened this issue Apr 10, 2023 · 8 comments · Fixed by #10604
Closed
2 tasks

Change the hero image to a new illustration on the wallet page #9940

nloureiro opened this issue Apr 10, 2023 · 8 comments · Fixed by #10604
Assignees
@corwintines @daredevil3435
Labels
design All the issues related to design should use this tag feature ✨ This is enhancing something existing or creating something new needs triage 📥 This issue needs triaged before being worked on Status: Stale This issue is stale because it has been open 30 days with no activity.

Comments

@nloureiro
Copy link
Contributor

Is your feature request related to a problem? Please describe.

On the Ai Illustration EPIC, we agree that some pages can be updated with Ai-generated images to create a more dynamic experience and not overuse the same illustrations.

Describe the solution you'd like

For the first illustration, we will replace the one on the wallet page with this one.
https://ethereum.org/en/wallets/

wallet_illustration

Figma mockup
Screen Shot 2023-04-10 02 11 32 PM

Describe alternatives you've considered

none

Additional context

No response

Would you like to work on this issue?

  • Yes
  • No
@nloureiro nloureiro added feature ✨ This is enhancing something existing or creating something new design All the issues related to design should use this tag labels Apr 10, 2023
@github-actions github-actions bot added the needs triage 📥 This issue needs triaged before being worked on label Apr 10, 2023
@daredevil3435
Copy link

daredevil3435 commented Apr 13, 2023 •
edited
Loading

@nloureiro I would like to contribute to this issue. How do I get started with?

@nloureiro
Copy link
Contributor Author

@nloureiro I would like to contribute to this issue. How do I get started with?

oh nice!

The basic idea on this is to replace the image on this page, can you do a PR with the image change?

@daredevil3435
Copy link

@nloureiro I would like to contribute to this issue. How do I get started with?

oh nice!

The basic idea on this is to replace the image on this page, can you do a PR with the image change?

Yes. Happy to contribute. But how do I find the files in large codebase. I checked but it's kinda overwhelming!! Guide me through this. Thank you!!

@nloureiro
Copy link
Contributor Author

@nloureiro I would like to contribute to this issue. How do I get started with?

oh nice!
The basic idea on this is to replace the image on this page, can you do a PR with the image change?

Yes. Happy to contribute. But how do I find the files in large codebase. I checked but it's kinda overwhelming!! Guide me through this. Thank you!!

No worries, @pettinarip or @corwintines can you help here? :)

@corwintines
Copy link
Member

corwintines commented Apr 17, 2023 •
edited
Loading

@daredevil3435 you'll need to:

  • Add this new image asset into the assets folder
  • In /src/page-conditionals/wallets.tsx youll need to update the graphql query for the hero image to this new image

Thanks!

@corwintines corwintines self-assigned this Apr 17, 2023
@daredevil3435
Copy link

@daredevil3435 you'll need to:

  • Add this new image asset into the assets folder
  • In /src/page-conditionals/wallets.tsx youll need to update the graphql query for the hero image to this new image

Thanks!

thanks for the help!! I'll submit PR soon

@daredevil3435
Copy link

I did the changes as you said but I'm getting error on testing about Query.

@github-actions
Copy link
Contributor

github-actions bot commented Jun 2, 2023

This issue is stale because it has been open 45 days with no activity.

@github-actions github-actions bot added the Status: Stale This issue is stale because it has been open 30 days with no activity. label Jun 2, 2023
@corwintines corwintines mentioned this issue Jul 4, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@corwintines corwintines

@daredevil3435 daredevil3435

Labels
design All the issues related to design should use this tag feature ✨ This is enhancing something existing or creating something new needs triage 📥 This issue needs triaged before being worked on Status: Stale This issue is stale because it has been open 30 days with no activity.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

add new wallet hero image ethereum/ethereum-org-website
3 participants
@nloureiro @corwintines @daredevil3435