From 2882732fbc9fd69b9a456c9ef461638fbfab71d6 Mon Sep 17 00:00:00 2001 From: Sam Richards Date: Mon, 23 May 2022 21:03:57 +0200 Subject: [PATCH 01/55] Copy over content from GH issue (#6434) --- .github/ISSUE_TEMPLATE/suggest_wallet.md | 211 +++++++++++++---------- 1 file changed, 116 insertions(+), 95 deletions(-) diff --git a/.github/ISSUE_TEMPLATE/suggest_wallet.md b/.github/ISSUE_TEMPLATE/suggest_wallet.md index 2a8363c7fbe..adede508700 100644 --- a/.github/ISSUE_TEMPLATE/suggest_wallet.md +++ b/.github/ISSUE_TEMPLATE/suggest_wallet.md @@ -6,98 +6,119 @@ labels: "wallet :purse:," assignees: "" --- -_Please note as part of [our Q2 product roadmap](https://github.com/ethereum/ethereum-org-website/issues/6161) we paused adding new wallets until we establish new, expanded criteria._ - -Before suggesting a wallet, make sure you've read [our listing policy](https://www.ethereum.org/en/contributing/adding-products/). - -Only continue with the issue if your wallet meets the criteria listed there. - -If it does complete the following information which we need to accurately list the wallet. - -**Is your wallet security tested? Please explain security measures i.e. security audit, internal security team or some other method.** - - - -**When did your wallet go live to users?** - - - -**Does your wallet have an active development team?** - - - -**Is your wallet open-source?** - - - -**Is your wallet globally accessible?** - - - -**Is your wallet custodial, non-custodial, or a hardware wallet?** - - - -**Please describe the measures taken to ensure the wallet's security and provide documentation wherever possible** - - - -**Does the wallet support layer 2 networks?** - - - -**Can the wallet be used with arbitrary Ethereum RPC endpoint?** - - - -**Does the wallet have fiat on-ramps?** - - - -**Does the wallet allow users to explore dapps?** - - - -**Does the wallet have integrated defi/financial tools?** - - - -**Can a user withdraw to their card?** - - - -**Does the wallet offer limits protection?** - - - -**Does the wallet allow high-volume purchases?** - - - -**Does the wallet have an integrated token swap?** - - - -**Is the wallet a multi-signature wallet?** - - - -**Wallet title** - - - -**Wallet description** - - - -**Wallet logo** - - - -**Background colour for brand logo** - - - -**URL** - - +Before suggesting a wallet, make sure you've read [our listing policy](https://www.ethereum.org/en/contributing/adding-products/). Only continue with the issue if your wallet meets the criteria listed there. + +If the wallet does meet our list policy, please complete the following information which we need to accurately list the wallet. + +### Project info + +- Wallet name + - Please provide the official name of the wallet +- Wallet description + - Please provide a short 1-2 sentence description of the wallet without marketing claims. Avoid claims like “the best Ethereum wallet”. We will ask for revisions if this comes across as marketing-focused. +- Wallet logo + - Please provide a hi-res SVG or transparent PNG +- Background color for brand logo + - Please provide a hex code for the brand color. This will be added to the background of the wallet card. +- URL to the project + - Please provide a URL (e.g. to the website of the wallet) +- URL to the documentation + - Please provide a URL to the documentation +- Is your wallet security tested? Please explain security measures i.e. security audit, internal security team, or some other method. + - Please explain any security measures you have taken to ensure your wallet is secure +- When did your wallet go live to users? + - Please provide a date when your wallet was usable by the public. Please provide some user metrics for how many users are using this wallet. +- Does your wallet have an active development team? + - Are developers actively working on the wallet? Provide proof that the wallet is actively being worked on (ex. GitHub repo link). +- Is your wallet globally accessible? + - Please list any KYC requirements or geographic limitations of your wallet, if any exist. +- Is there internationalization support for your wallet? + - Please list languages that the wallet actively supports +- What is the repository for your codebase? + - If you’re project is open source, please provide a link to the codebase. +- What social links are there for the project? + - Please provide social links for the wallet (Discord, Twitter, etc.) +- What is your wallet's onboarding experience? + - Please provide an explanation of where to find the user onboarding experience (links, is it built into the app, etc.), and what the onboarding experience is. + +### Device + +- Does the wallet have a mobile app? If yes, which operating systems are supported (iOS, Android)? + - If the wallet has a mobile interface, please provide information and links to the app store for the operating systems supported. +- Does the wallet have a desktop app? If yes, which operating systems are supported (Windows, Mac, Linux)? + - If the wallet has a desktop interface, please provide links and information for the operating systems supported. +- Does the wallet have a browser extension? If yes, which browsers are supported (Chromium, Firefox, Safari)? + - If the wallet has a browser extension, please provide links and information for the browsers that are supported. +- Is it a hardware wallet? + - How is it used / how does it connect (e.g. USB)? What software wallets does it integrate with (e.g. MetaMask)? + +### Security + +- Is the wallet code open-sourced? + - If yes, please provide a direct link to the repository. +- What license was the wallet software released under? + - Please provide information on the software license used for the wallet. +- Is your wallet custodial, or non-custodial? + - Do users have access to their public and/or private keys? If your company/project were to disappear, would users still be able to access their funds? + - Custodial - users don't own keys + - Non-custodial - users own keys +- Please describe the measures taken to ensure the wallet's security and provide documentation wherever possible + - Please provide a link to any security audits or code reports. If you haven't been audited but think your wallet should be listed anyway, explain here. +- Spam protection? + - Does the wallet employ any practices to warn users against potential spam (e.g. when interacting with suspicious accounts/contracts)? + +### Features + +- Does the wallet have hardware wallet support? + - Please provide information on how a user can connect a hardware wallet to this wallet. +- Does the wallet support WalletConnect? + - Please provide information on if the wallet supports WalletConnect. +- Does the wallet support importing Ethereum RPC endpoints? + - Please provide documentation on how a user can import an Ethereum RPC into the wallet. +- Does the wallet support viewing and interacting with NFTs? + - Please provide information on the experience of NFTs in the wallet. +- Does the wallet support connecting to Ethereum applications? + - Please provide documentation for how users connect to applications. List examples (ie. connect wallet to dapp, in wallet browser, etc.) +- Does the wallet support staking directly? + - Please provide documentation on direct staking this wallet supports. +- Does the wallet support swaps directly? + - Please provide documentation on swaps. +- Does the wallet support multi-chain networks? + - Please provide documentation on multi-chain networks this wallet supports. +- Does the wallet allow the user to customize gas fees? + - Please provide documentation on how users can customize gas fees for transactions. +- Does the wallet support ENS? + - Please provide information on ENS support. +- Does the wallet support importing or automatically querying and displaying ERC-20 tokens? + - Please provide documentation on how to import tokens into the wallet. +- Does the wallet support EIP-1559 style transactions? + - Please provide information on how the type of transactions this wallet supports. + +### Finance + +- Does the wallet have fiat on-ramps through credit/debit cards or wire transfers, or Bank transfers (ACH)? + - Please provide documentation on how a user is able to onboard and purchase crypto in the wallet. + - Credit/debit cards + - Wire transfer + - Bank Transfer (ACH) +- Does the wallet support withdrawals to fiat? + - Can a user cash out their crypto assets directly to a card or bank account? Please provide documentation. + +### Smart Contract + +- Is the wallet a multi-signature wallet? + - Please provide documentation on how users set up and use the multisig functionality for the wallet. +- Does the wallet support social recovery? + - Please provide documentation on how users set up guardians and use social recovery for the wallet. + +### Support + +- Does your wallet have a dedicated support team? + - Where should we send users that are having issues? + - How fast is your support? +- What educational resources/documentation do you provide to users? + +### Extra + +- Does the wallet have any integrated tools not mentioned above? + - Please provide any information about extra features this wallet has that we may have missed in the above criteria. (e.g. privacy features, transaction batching, etc). From 8499ca549f02084b0ea208acdac5c2428ee9e044 Mon Sep 17 00:00:00 2001 From: Sam Richards Date: Mon, 23 May 2022 21:08:49 +0200 Subject: [PATCH 02/55] Format template --- .github/ISSUE_TEMPLATE/suggest_wallet.md | 251 +++++++++++++++-------- 1 file changed, 162 insertions(+), 89 deletions(-) diff --git a/.github/ISSUE_TEMPLATE/suggest_wallet.md b/.github/ISSUE_TEMPLATE/suggest_wallet.md index adede508700..9d73ccc85a4 100644 --- a/.github/ISSUE_TEMPLATE/suggest_wallet.md +++ b/.github/ISSUE_TEMPLATE/suggest_wallet.md @@ -12,113 +12,186 @@ If the wallet does meet our list policy, please complete the following informati ### Project info -- Wallet name - - Please provide the official name of the wallet -- Wallet description - - Please provide a short 1-2 sentence description of the wallet without marketing claims. Avoid claims like “the best Ethereum wallet”. We will ask for revisions if this comes across as marketing-focused. -- Wallet logo - - Please provide a hi-res SVG or transparent PNG -- Background color for brand logo - - Please provide a hex code for the brand color. This will be added to the background of the wallet card. -- URL to the project - - Please provide a URL (e.g. to the website of the wallet) -- URL to the documentation - - Please provide a URL to the documentation -- Is your wallet security tested? Please explain security measures i.e. security audit, internal security team, or some other method. - - Please explain any security measures you have taken to ensure your wallet is secure -- When did your wallet go live to users? - - Please provide a date when your wallet was usable by the public. Please provide some user metrics for how many users are using this wallet. -- Does your wallet have an active development team? - - Are developers actively working on the wallet? Provide proof that the wallet is actively being worked on (ex. GitHub repo link). -- Is your wallet globally accessible? - - Please list any KYC requirements or geographic limitations of your wallet, if any exist. -- Is there internationalization support for your wallet? - - Please list languages that the wallet actively supports -- What is the repository for your codebase? - - If you’re project is open source, please provide a link to the codebase. -- What social links are there for the project? - - Please provide social links for the wallet (Discord, Twitter, etc.) -- What is your wallet's onboarding experience? - - Please provide an explanation of where to find the user onboarding experience (links, is it built into the app, etc.), and what the onboarding experience is. +**Wallet name** + + + +**Wallet description** + + + +**Wallet logo** + + + +**Background color for brand logo** + + + +**URL to the project** + + + +**URL to the documentation** + + + +**Is your wallet security tested? Please explain security measures i.e. security audit, internal security team, or some other method.** + + + +**When did your wallet go live to users?** + + + +**Does your wallet have an active development team?** + + + +**Is your wallet globally accessible?** + + + +**Is there internationalization support for your wallet?** + + + +**What is the repository for your codebase?** + + + +**What social links are there for the project?** + + + +**What is your wallet's onboarding experience?** + + ### Device -- Does the wallet have a mobile app? If yes, which operating systems are supported (iOS, Android)? - - If the wallet has a mobile interface, please provide information and links to the app store for the operating systems supported. -- Does the wallet have a desktop app? If yes, which operating systems are supported (Windows, Mac, Linux)? - - If the wallet has a desktop interface, please provide links and information for the operating systems supported. -- Does the wallet have a browser extension? If yes, which browsers are supported (Chromium, Firefox, Safari)? - - If the wallet has a browser extension, please provide links and information for the browsers that are supported. -- Is it a hardware wallet? - - How is it used / how does it connect (e.g. USB)? What software wallets does it integrate with (e.g. MetaMask)? +**Does the wallet have a mobile app? If yes, which operating systems are supported (iOS, Android)?** + + + +**Does the wallet have a desktop app? If yes, which operating systems are supported (Windows, Mac, Linux)?** + + + +**Does the wallet have a browser extension? If yes, which browsers are supported (Chromium, Firefox, Safari)?** + + + +**Is it a hardware wallet?** + + ### Security -- Is the wallet code open-sourced? - - If yes, please provide a direct link to the repository. -- What license was the wallet software released under? - - Please provide information on the software license used for the wallet. -- Is your wallet custodial, or non-custodial? - - Do users have access to their public and/or private keys? If your company/project were to disappear, would users still be able to access their funds? - - Custodial - users don't own keys - - Non-custodial - users own keys -- Please describe the measures taken to ensure the wallet's security and provide documentation wherever possible - - Please provide a link to any security audits or code reports. If you haven't been audited but think your wallet should be listed anyway, explain here. -- Spam protection? - - Does the wallet employ any practices to warn users against potential spam (e.g. when interacting with suspicious accounts/contracts)? +**Is the wallet code open-sourced?** + + + +**What license was the wallet software released under?** + + + +**Is your wallet custodial, or non-custodial?** + + + +**Please describe the measures taken to ensure the wallet's security and provide documentation wherever possible** + + + +**Spam protection?** + + ### Features -- Does the wallet have hardware wallet support? - - Please provide information on how a user can connect a hardware wallet to this wallet. -- Does the wallet support WalletConnect? - - Please provide information on if the wallet supports WalletConnect. -- Does the wallet support importing Ethereum RPC endpoints? - - Please provide documentation on how a user can import an Ethereum RPC into the wallet. -- Does the wallet support viewing and interacting with NFTs? - - Please provide information on the experience of NFTs in the wallet. -- Does the wallet support connecting to Ethereum applications? - - Please provide documentation for how users connect to applications. List examples (ie. connect wallet to dapp, in wallet browser, etc.) -- Does the wallet support staking directly? - - Please provide documentation on direct staking this wallet supports. -- Does the wallet support swaps directly? - - Please provide documentation on swaps. -- Does the wallet support multi-chain networks? - - Please provide documentation on multi-chain networks this wallet supports. -- Does the wallet allow the user to customize gas fees? - - Please provide documentation on how users can customize gas fees for transactions. -- Does the wallet support ENS? - - Please provide information on ENS support. -- Does the wallet support importing or automatically querying and displaying ERC-20 tokens? - - Please provide documentation on how to import tokens into the wallet. -- Does the wallet support EIP-1559 style transactions? - - Please provide information on how the type of transactions this wallet supports. +**Does the wallet have hardware wallet support?** + + + +**Does the wallet support WalletConnect?** + + + +**Does the wallet support importing Ethereum RPC endpoints?** + + + +**Does the wallet support viewing and interacting with NFTs?** + + + +**Does the wallet support connecting to Ethereum applications?** + + + +**Does the wallet support staking directly?** + + + +**Does the wallet support swaps directly?** + + + +**Does the wallet support multi-chain networks?** + + + +**Does the wallet allow the user to customize gas fees?** + + + +**Does the wallet support ENS?** + + + +**Does the wallet support importing or automatically querying and displaying ERC-20 tokens?** + + + +**Does the wallet support EIP-1559 style transactions?** + + ### Finance -- Does the wallet have fiat on-ramps through credit/debit cards or wire transfers, or Bank transfers (ACH)? - - Please provide documentation on how a user is able to onboard and purchase crypto in the wallet. - - Credit/debit cards - - Wire transfer - - Bank Transfer (ACH) -- Does the wallet support withdrawals to fiat? - - Can a user cash out their crypto assets directly to a card or bank account? Please provide documentation. +**Does the wallet have fiat on-ramps through credit/debit cards or wire transfers, or Bank transfers (ACH)?** + + + + + + +**Does the wallet support withdrawals to fiat?** + + ### Smart Contract -- Is the wallet a multi-signature wallet? - - Please provide documentation on how users set up and use the multisig functionality for the wallet. -- Does the wallet support social recovery? - - Please provide documentation on how users set up guardians and use social recovery for the wallet. +**Is the wallet a multi-signature wallet?** + + + +**Does the wallet support social recovery?** + + ### Support -- Does your wallet have a dedicated support team? - - Where should we send users that are having issues? - - How fast is your support? -- What educational resources/documentation do you provide to users? +**Does your wallet have a dedicated support team?** + + + + +**What educational resources/documentation do you provide to users?** ### Extra -- Does the wallet have any integrated tools not mentioned above? - - Please provide any information about extra features this wallet has that we may have missed in the above criteria. (e.g. privacy features, transaction batching, etc). +**Does the wallet have any integrated tools not mentioned above?** + + From e94d0274aaa271bc318ceadc76a6c2f92d7b5fec Mon Sep 17 00:00:00 2001 From: Corwin Smith Date: Tue, 24 May 2022 10:54:08 -0600 Subject: [PATCH 03/55] Update .github/ISSUE_TEMPLATE/suggest_wallet.md Co-authored-by: Sam Richards --- .github/ISSUE_TEMPLATE/suggest_wallet.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/ISSUE_TEMPLATE/suggest_wallet.md b/.github/ISSUE_TEMPLATE/suggest_wallet.md index 9d73ccc85a4..f38d90faaec 100644 --- a/.github/ISSUE_TEMPLATE/suggest_wallet.md +++ b/.github/ISSUE_TEMPLATE/suggest_wallet.md @@ -18,7 +18,7 @@ If the wallet does meet our list policy, please complete the following informati **Wallet description** - + **Wallet logo** From a03d908efa1686acff6fd599a05356466ee93d63 Mon Sep 17 00:00:00 2001 From: Corwin Smith Date: Tue, 24 May 2022 10:55:11 -0600 Subject: [PATCH 04/55] Update .github/ISSUE_TEMPLATE/suggest_wallet.md Co-authored-by: Joshua <62268199+minimalsm@users.noreply.github.com> --- .github/ISSUE_TEMPLATE/suggest_wallet.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/ISSUE_TEMPLATE/suggest_wallet.md b/.github/ISSUE_TEMPLATE/suggest_wallet.md index f38d90faaec..b3c583ebbf0 100644 --- a/.github/ISSUE_TEMPLATE/suggest_wallet.md +++ b/.github/ISSUE_TEMPLATE/suggest_wallet.md @@ -92,7 +92,7 @@ If the wallet does meet our list policy, please complete the following informati -**What license was the wallet software released under?** +**What license is the wallet software released under?** From 82826e12dd8911d50b1f63ecd482f0dbf77ff93b Mon Sep 17 00:00:00 2001 From: Corwin Smith Date: Tue, 24 May 2022 10:56:09 -0600 Subject: [PATCH 05/55] Update .github/ISSUE_TEMPLATE/suggest_wallet.md Co-authored-by: Joshua <62268199+minimalsm@users.noreply.github.com> --- .github/ISSUE_TEMPLATE/suggest_wallet.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/ISSUE_TEMPLATE/suggest_wallet.md b/.github/ISSUE_TEMPLATE/suggest_wallet.md index b3c583ebbf0..667a928c076 100644 --- a/.github/ISSUE_TEMPLATE/suggest_wallet.md +++ b/.github/ISSUE_TEMPLATE/suggest_wallet.md @@ -36,7 +36,7 @@ If the wallet does meet our list policy, please complete the following informati -**Is your wallet security tested? Please explain security measures i.e. security audit, internal security team, or some other method.** +**Is the wallet security tested? Please explain security measures i.e. security audit, internal security team, or some other method.** From ab182e2b0473b7cbdf773ae24476ac98625f331d Mon Sep 17 00:00:00 2001 From: Corwin Smith Date: Tue, 24 May 2022 10:56:58 -0600 Subject: [PATCH 06/55] Update .github/ISSUE_TEMPLATE/suggest_wallet.md Co-authored-by: Sam Richards --- .github/ISSUE_TEMPLATE/suggest_wallet.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/ISSUE_TEMPLATE/suggest_wallet.md b/.github/ISSUE_TEMPLATE/suggest_wallet.md index 667a928c076..df347b4e5e7 100644 --- a/.github/ISSUE_TEMPLATE/suggest_wallet.md +++ b/.github/ISSUE_TEMPLATE/suggest_wallet.md @@ -98,7 +98,7 @@ If the wallet does meet our list policy, please complete the following informati **Is your wallet custodial, or non-custodial?** - + **Please describe the measures taken to ensure the wallet's security and provide documentation wherever possible** From a3b2fc10499d8b23889dd8df2c2f74a3165ffad7 Mon Sep 17 00:00:00 2001 From: Corwin Smith Date: Tue, 24 May 2022 20:32:34 -0600 Subject: [PATCH 07/55] Update .github/ISSUE_TEMPLATE/suggest_wallet.md Co-authored-by: Joshua <62268199+minimalsm@users.noreply.github.com> --- .github/ISSUE_TEMPLATE/suggest_wallet.md | 1 - 1 file changed, 1 deletion(-) diff --git a/.github/ISSUE_TEMPLATE/suggest_wallet.md b/.github/ISSUE_TEMPLATE/suggest_wallet.md index df347b4e5e7..da8d135d698 100644 --- a/.github/ISSUE_TEMPLATE/suggest_wallet.md +++ b/.github/ISSUE_TEMPLATE/suggest_wallet.md @@ -8,7 +8,6 @@ assignees: "" Before suggesting a wallet, make sure you've read [our listing policy](https://www.ethereum.org/en/contributing/adding-products/). Only continue with the issue if your wallet meets the criteria listed there. -If the wallet does meet our list policy, please complete the following information which we need to accurately list the wallet. ### Project info From ac47cc7f82467b815ab987b3606b1985e6255d58 Mon Sep 17 00:00:00 2001 From: Corwin Smith Date: Tue, 24 May 2022 20:32:59 -0600 Subject: [PATCH 08/55] Update .github/ISSUE_TEMPLATE/suggest_wallet.md Co-authored-by: Paul Wackerow <54227730+wackerow@users.noreply.github.com> --- .github/ISSUE_TEMPLATE/suggest_wallet.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/ISSUE_TEMPLATE/suggest_wallet.md b/.github/ISSUE_TEMPLATE/suggest_wallet.md index da8d135d698..9c08c43060f 100644 --- a/.github/ISSUE_TEMPLATE/suggest_wallet.md +++ b/.github/ISSUE_TEMPLATE/suggest_wallet.md @@ -21,7 +21,7 @@ Before suggesting a wallet, make sure you've read [our listing policy](https://w **Wallet logo** - + **Background color for brand logo** From 39ddd6ee34692a72fda9d65d2ee39ec998a193d5 Mon Sep 17 00:00:00 2001 From: Corwin Smith Date: Tue, 24 May 2022 20:42:00 -0600 Subject: [PATCH 09/55] Update .github/ISSUE_TEMPLATE/suggest_wallet.md Co-authored-by: Sam Richards --- .github/ISSUE_TEMPLATE/suggest_wallet.md | 1 + 1 file changed, 1 insertion(+) diff --git a/.github/ISSUE_TEMPLATE/suggest_wallet.md b/.github/ISSUE_TEMPLATE/suggest_wallet.md index 9c08c43060f..5e571fe216b 100644 --- a/.github/ISSUE_TEMPLATE/suggest_wallet.md +++ b/.github/ISSUE_TEMPLATE/suggest_wallet.md @@ -189,6 +189,7 @@ Before suggesting a wallet, make sure you've read [our listing policy](https://w **What educational resources/documentation do you provide to users?** + ### Extra **Does the wallet have any integrated tools not mentioned above?** From 7e053e9ef183abfffb87c891b9336d25d85a64e3 Mon Sep 17 00:00:00 2001 From: Corwin Smith Date: Tue, 24 May 2022 20:42:50 -0600 Subject: [PATCH 10/55] Update .github/ISSUE_TEMPLATE/suggest_wallet.md --- .github/ISSUE_TEMPLATE/suggest_wallet.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/ISSUE_TEMPLATE/suggest_wallet.md b/.github/ISSUE_TEMPLATE/suggest_wallet.md index 5e571fe216b..99f143eac79 100644 --- a/.github/ISSUE_TEMPLATE/suggest_wallet.md +++ b/.github/ISSUE_TEMPLATE/suggest_wallet.md @@ -189,7 +189,7 @@ Before suggesting a wallet, make sure you've read [our listing policy](https://w **What educational resources/documentation do you provide to users?** - + ### Extra **Does the wallet have any integrated tools not mentioned above?** From 6c37a98d11025811528e5f6ebf274679fd11cbb0 Mon Sep 17 00:00:00 2001 From: Corwin Smith Date: Tue, 24 May 2022 20:56:21 -0600 Subject: [PATCH 11/55] Update .github/ISSUE_TEMPLATE/suggest_wallet.md Co-authored-by: Sam Richards --- .github/ISSUE_TEMPLATE/suggest_wallet.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/ISSUE_TEMPLATE/suggest_wallet.md b/.github/ISSUE_TEMPLATE/suggest_wallet.md index 99f143eac79..45b18b3d22b 100644 --- a/.github/ISSUE_TEMPLATE/suggest_wallet.md +++ b/.github/ISSUE_TEMPLATE/suggest_wallet.md @@ -41,7 +41,7 @@ Before suggesting a wallet, make sure you've read [our listing policy](https://w **When did your wallet go live to users?** - + **Does your wallet have an active development team?** From a5f11e0ea67389db36bb5bb683c68195db75401d Mon Sep 17 00:00:00 2001 From: Corwin Smith Date: Tue, 24 May 2022 20:56:40 -0600 Subject: [PATCH 12/55] Update .github/ISSUE_TEMPLATE/suggest_wallet.md Co-authored-by: Joshua <62268199+minimalsm@users.noreply.github.com> --- .github/ISSUE_TEMPLATE/suggest_wallet.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/ISSUE_TEMPLATE/suggest_wallet.md b/.github/ISSUE_TEMPLATE/suggest_wallet.md index 45b18b3d22b..37470afbf59 100644 --- a/.github/ISSUE_TEMPLATE/suggest_wallet.md +++ b/.github/ISSUE_TEMPLATE/suggest_wallet.md @@ -51,7 +51,7 @@ Before suggesting a wallet, make sure you've read [our listing policy](https://w -**Is there internationalization support for your wallet?** +**Is the wallet available in multiple languages?** From c9f471a906d068a4fdcaa2bfdd5547e7340d3fc6 Mon Sep 17 00:00:00 2001 From: Corwin Smith Date: Tue, 24 May 2022 21:00:43 -0600 Subject: [PATCH 13/55] Update suggest_wallet.md --- .github/ISSUE_TEMPLATE/suggest_wallet.md | 4 ---- 1 file changed, 4 deletions(-) diff --git a/.github/ISSUE_TEMPLATE/suggest_wallet.md b/.github/ISSUE_TEMPLATE/suggest_wallet.md index 37470afbf59..0bbabeb0ec7 100644 --- a/.github/ISSUE_TEMPLATE/suggest_wallet.md +++ b/.github/ISSUE_TEMPLATE/suggest_wallet.md @@ -55,10 +55,6 @@ Before suggesting a wallet, make sure you've read [our listing policy](https://w -**What is the repository for your codebase?** - - - **What social links are there for the project?** From 3b6145a023bbb4945b32361afd0ad9e4e725051a Mon Sep 17 00:00:00 2001 From: Corwin Smith Date: Tue, 24 May 2022 21:01:42 -0600 Subject: [PATCH 14/55] Update suggest_wallet.md --- .github/ISSUE_TEMPLATE/suggest_wallet.md | 4 ---- 1 file changed, 4 deletions(-) diff --git a/.github/ISSUE_TEMPLATE/suggest_wallet.md b/.github/ISSUE_TEMPLATE/suggest_wallet.md index 0bbabeb0ec7..ee125b3d2e3 100644 --- a/.github/ISSUE_TEMPLATE/suggest_wallet.md +++ b/.github/ISSUE_TEMPLATE/suggest_wallet.md @@ -59,10 +59,6 @@ Before suggesting a wallet, make sure you've read [our listing policy](https://w -**What is your wallet's onboarding experience?** - - - ### Device **Does the wallet have a mobile app? If yes, which operating systems are supported (iOS, Android)?** From 722f04f9bd54860ee53191bcfb0f4079b819646b Mon Sep 17 00:00:00 2001 From: Corwin Smith Date: Tue, 24 May 2022 21:04:19 -0600 Subject: [PATCH 15/55] Update .github/ISSUE_TEMPLATE/suggest_wallet.md Co-authored-by: Sam Richards --- .github/ISSUE_TEMPLATE/suggest_wallet.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/ISSUE_TEMPLATE/suggest_wallet.md b/.github/ISSUE_TEMPLATE/suggest_wallet.md index ee125b3d2e3..2dd3351bc0f 100644 --- a/.github/ISSUE_TEMPLATE/suggest_wallet.md +++ b/.github/ISSUE_TEMPLATE/suggest_wallet.md @@ -63,7 +63,7 @@ Before suggesting a wallet, make sure you've read [our listing policy](https://w **Does the wallet have a mobile app? If yes, which operating systems are supported (iOS, Android)?** - + **Does the wallet have a desktop app? If yes, which operating systems are supported (Windows, Mac, Linux)?** From 4994d77966be0a7a7a4c5e33cc58c5489c4bc0bf Mon Sep 17 00:00:00 2001 From: Corwin Smith Date: Tue, 24 May 2022 21:04:32 -0600 Subject: [PATCH 16/55] Update .github/ISSUE_TEMPLATE/suggest_wallet.md Co-authored-by: Sam Richards --- .github/ISSUE_TEMPLATE/suggest_wallet.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/ISSUE_TEMPLATE/suggest_wallet.md b/.github/ISSUE_TEMPLATE/suggest_wallet.md index 2dd3351bc0f..d0e5924771c 100644 --- a/.github/ISSUE_TEMPLATE/suggest_wallet.md +++ b/.github/ISSUE_TEMPLATE/suggest_wallet.md @@ -67,7 +67,7 @@ Before suggesting a wallet, make sure you've read [our listing policy](https://w **Does the wallet have a desktop app? If yes, which operating systems are supported (Windows, Mac, Linux)?** - + **Does the wallet have a browser extension? If yes, which browsers are supported (Chromium, Firefox, Safari)?** From 569fc8534664d3c90df34710fb0e4f79ce201854 Mon Sep 17 00:00:00 2001 From: Corwin Smith Date: Tue, 24 May 2022 21:04:40 -0600 Subject: [PATCH 17/55] Update .github/ISSUE_TEMPLATE/suggest_wallet.md Co-authored-by: Sam Richards --- .github/ISSUE_TEMPLATE/suggest_wallet.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/ISSUE_TEMPLATE/suggest_wallet.md b/.github/ISSUE_TEMPLATE/suggest_wallet.md index d0e5924771c..966f02c21f9 100644 --- a/.github/ISSUE_TEMPLATE/suggest_wallet.md +++ b/.github/ISSUE_TEMPLATE/suggest_wallet.md @@ -71,7 +71,7 @@ Before suggesting a wallet, make sure you've read [our listing policy](https://w **Does the wallet have a browser extension? If yes, which browsers are supported (Chromium, Firefox, Safari)?** - + **Is it a hardware wallet?** From 09e63fdc0b53c991baa03fe672e4c723cb246a78 Mon Sep 17 00:00:00 2001 From: Corwin Smith Date: Tue, 24 May 2022 21:04:51 -0600 Subject: [PATCH 18/55] Update .github/ISSUE_TEMPLATE/suggest_wallet.md Co-authored-by: Sam Richards --- .github/ISSUE_TEMPLATE/suggest_wallet.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/ISSUE_TEMPLATE/suggest_wallet.md b/.github/ISSUE_TEMPLATE/suggest_wallet.md index 966f02c21f9..7fa118a9bd2 100644 --- a/.github/ISSUE_TEMPLATE/suggest_wallet.md +++ b/.github/ISSUE_TEMPLATE/suggest_wallet.md @@ -75,7 +75,7 @@ Before suggesting a wallet, make sure you've read [our listing policy](https://w **Is it a hardware wallet?** - + ### Security From 293634c9b42c049eaeb2018f8e856fec0fa526d1 Mon Sep 17 00:00:00 2001 From: Corwin Smith Date: Tue, 24 May 2022 21:07:31 -0600 Subject: [PATCH 19/55] Update .github/ISSUE_TEMPLATE/suggest_wallet.md --- .github/ISSUE_TEMPLATE/suggest_wallet.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/ISSUE_TEMPLATE/suggest_wallet.md b/.github/ISSUE_TEMPLATE/suggest_wallet.md index 7fa118a9bd2..89f143361e7 100644 --- a/.github/ISSUE_TEMPLATE/suggest_wallet.md +++ b/.github/ISSUE_TEMPLATE/suggest_wallet.md @@ -75,7 +75,7 @@ Before suggesting a wallet, make sure you've read [our listing policy](https://w **Is it a hardware wallet?** - + ### Security From 11f73429deae2ea504941fde008d04d17799e6d7 Mon Sep 17 00:00:00 2001 From: Corwin Smith Date: Tue, 24 May 2022 21:08:09 -0600 Subject: [PATCH 20/55] Update .github/ISSUE_TEMPLATE/suggest_wallet.md Co-authored-by: Joshua <62268199+minimalsm@users.noreply.github.com> --- .github/ISSUE_TEMPLATE/suggest_wallet.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/ISSUE_TEMPLATE/suggest_wallet.md b/.github/ISSUE_TEMPLATE/suggest_wallet.md index 89f143361e7..efb969b4c54 100644 --- a/.github/ISSUE_TEMPLATE/suggest_wallet.md +++ b/.github/ISSUE_TEMPLATE/suggest_wallet.md @@ -79,7 +79,7 @@ Before suggesting a wallet, make sure you've read [our listing policy](https://w ### Security -**Is the wallet code open-sourced?** +**Is the source code for the wallet fully open-source?** From 0b340cdd8f9723dfc46bd4c95e989ac53637e8e3 Mon Sep 17 00:00:00 2001 From: Corwin Smith Date: Tue, 24 May 2022 21:09:39 -0600 Subject: [PATCH 21/55] Update .github/ISSUE_TEMPLATE/suggest_wallet.md Co-authored-by: Sam Richards --- .github/ISSUE_TEMPLATE/suggest_wallet.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/ISSUE_TEMPLATE/suggest_wallet.md b/.github/ISSUE_TEMPLATE/suggest_wallet.md index efb969b4c54..555cba07d7a 100644 --- a/.github/ISSUE_TEMPLATE/suggest_wallet.md +++ b/.github/ISSUE_TEMPLATE/suggest_wallet.md @@ -93,7 +93,7 @@ Before suggesting a wallet, make sure you've read [our listing policy](https://w **Please describe the measures taken to ensure the wallet's security and provide documentation wherever possible** - + **Spam protection?** From fa2779cff73fdc06959e72edc192bae810a7ffd3 Mon Sep 17 00:00:00 2001 From: Corwin Smith Date: Tue, 24 May 2022 21:10:42 -0600 Subject: [PATCH 22/55] Update .github/ISSUE_TEMPLATE/suggest_wallet.md Co-authored-by: Sam Richards --- .github/ISSUE_TEMPLATE/suggest_wallet.md | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/.github/ISSUE_TEMPLATE/suggest_wallet.md b/.github/ISSUE_TEMPLATE/suggest_wallet.md index 555cba07d7a..a2d180613c1 100644 --- a/.github/ISSUE_TEMPLATE/suggest_wallet.md +++ b/.github/ISSUE_TEMPLATE/suggest_wallet.md @@ -87,7 +87,9 @@ Before suggesting a wallet, make sure you've read [our listing policy](https://w -**Is your wallet custodial, or non-custodial?** +**Who holds the private keys?** + + From abf92f87add7cbc64a4396b6e30d7501c02c6d76 Mon Sep 17 00:00:00 2001 From: Corwin Smith Date: Tue, 24 May 2022 21:10:59 -0600 Subject: [PATCH 23/55] Update .github/ISSUE_TEMPLATE/suggest_wallet.md Co-authored-by: Joshua <62268199+minimalsm@users.noreply.github.com> --- .github/ISSUE_TEMPLATE/suggest_wallet.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/ISSUE_TEMPLATE/suggest_wallet.md b/.github/ISSUE_TEMPLATE/suggest_wallet.md index a2d180613c1..680e56553c6 100644 --- a/.github/ISSUE_TEMPLATE/suggest_wallet.md +++ b/.github/ISSUE_TEMPLATE/suggest_wallet.md @@ -103,7 +103,7 @@ Before suggesting a wallet, make sure you've read [our listing policy](https://w ### Features -**Does the wallet have hardware wallet support?** +**Does the wallet support connecting to a hardware wallet?** From c2a8183f32e30b90d3df60163453bde41e621e23 Mon Sep 17 00:00:00 2001 From: Corwin Smith Date: Tue, 24 May 2022 21:13:27 -0600 Subject: [PATCH 24/55] Update .github/ISSUE_TEMPLATE/suggest_wallet.md --- .github/ISSUE_TEMPLATE/suggest_wallet.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/ISSUE_TEMPLATE/suggest_wallet.md b/.github/ISSUE_TEMPLATE/suggest_wallet.md index 680e56553c6..245439ff8f1 100644 --- a/.github/ISSUE_TEMPLATE/suggest_wallet.md +++ b/.github/ISSUE_TEMPLATE/suggest_wallet.md @@ -109,7 +109,7 @@ Before suggesting a wallet, make sure you've read [our listing policy](https://w **Does the wallet support WalletConnect?** - + **Does the wallet support importing Ethereum RPC endpoints?** From 7494f9f8ce9d6a65eb787900a16d2e583d8eea93 Mon Sep 17 00:00:00 2001 From: Corwin Smith Date: Tue, 24 May 2022 21:18:23 -0600 Subject: [PATCH 25/55] Update .github/ISSUE_TEMPLATE/suggest_wallet.md Co-authored-by: Joshua <62268199+minimalsm@users.noreply.github.com> --- .github/ISSUE_TEMPLATE/suggest_wallet.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/ISSUE_TEMPLATE/suggest_wallet.md b/.github/ISSUE_TEMPLATE/suggest_wallet.md index 245439ff8f1..cea586fdec1 100644 --- a/.github/ISSUE_TEMPLATE/suggest_wallet.md +++ b/.github/ISSUE_TEMPLATE/suggest_wallet.md @@ -139,7 +139,7 @@ Before suggesting a wallet, make sure you've read [our listing policy](https://w -**Does the wallet support ENS?** +**Does the wallet support sending transactions to ENS addresses?** From 49c6e0a22351b5f6a05e9827df054577a4dabbfd Mon Sep 17 00:00:00 2001 From: Corwin Smith Date: Tue, 24 May 2022 21:18:33 -0600 Subject: [PATCH 26/55] Update .github/ISSUE_TEMPLATE/suggest_wallet.md Co-authored-by: Joshua <62268199+minimalsm@users.noreply.github.com> --- .github/ISSUE_TEMPLATE/suggest_wallet.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/ISSUE_TEMPLATE/suggest_wallet.md b/.github/ISSUE_TEMPLATE/suggest_wallet.md index cea586fdec1..9d89c8ff234 100644 --- a/.github/ISSUE_TEMPLATE/suggest_wallet.md +++ b/.github/ISSUE_TEMPLATE/suggest_wallet.md @@ -147,7 +147,7 @@ Before suggesting a wallet, make sure you've read [our listing policy](https://w -**Does the wallet support EIP-1559 style transactions?** +**Does the wallet support EIP-1559 (type 2) transactions?** From 2814fd41f768bfb07def0defe8bde4d3c4d53459 Mon Sep 17 00:00:00 2001 From: Corwin Smith Date: Tue, 24 May 2022 21:18:43 -0600 Subject: [PATCH 27/55] Update .github/ISSUE_TEMPLATE/suggest_wallet.md Co-authored-by: Sam Richards --- .github/ISSUE_TEMPLATE/suggest_wallet.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/ISSUE_TEMPLATE/suggest_wallet.md b/.github/ISSUE_TEMPLATE/suggest_wallet.md index 9d89c8ff234..216270122b7 100644 --- a/.github/ISSUE_TEMPLATE/suggest_wallet.md +++ b/.github/ISSUE_TEMPLATE/suggest_wallet.md @@ -153,7 +153,7 @@ Before suggesting a wallet, make sure you've read [our listing policy](https://w ### Finance -**Does the wallet have fiat on-ramps through credit/debit cards or wire transfers, or Bank transfers (ACH)?** +**Does the wallet have fiat on-ramps through credit/debit cards, wire transfers, or bank transfers (ACH)?** From 887c27daa7d9bbe548493a15ded173d6ceb32267 Mon Sep 17 00:00:00 2001 From: Corwin Smith Date: Tue, 24 May 2022 21:19:36 -0600 Subject: [PATCH 28/55] Update suggest_wallet.md --- .github/ISSUE_TEMPLATE/suggest_wallet.md | 3 --- 1 file changed, 3 deletions(-) diff --git a/.github/ISSUE_TEMPLATE/suggest_wallet.md b/.github/ISSUE_TEMPLATE/suggest_wallet.md index 216270122b7..05dc0aa5827 100644 --- a/.github/ISSUE_TEMPLATE/suggest_wallet.md +++ b/.github/ISSUE_TEMPLATE/suggest_wallet.md @@ -156,9 +156,6 @@ Before suggesting a wallet, make sure you've read [our listing policy](https://w **Does the wallet have fiat on-ramps through credit/debit cards, wire transfers, or bank transfers (ACH)?** - - - **Does the wallet support withdrawals to fiat?** From 79f0b218095f5483db8d481f1eff55cb6e6929d0 Mon Sep 17 00:00:00 2001 From: Corwin Smith Date: Tue, 24 May 2022 21:19:53 -0600 Subject: [PATCH 29/55] Update .github/ISSUE_TEMPLATE/suggest_wallet.md Co-authored-by: Joshua <62268199+minimalsm@users.noreply.github.com> --- .github/ISSUE_TEMPLATE/suggest_wallet.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/ISSUE_TEMPLATE/suggest_wallet.md b/.github/ISSUE_TEMPLATE/suggest_wallet.md index 05dc0aa5827..92783d062fa 100644 --- a/.github/ISSUE_TEMPLATE/suggest_wallet.md +++ b/.github/ISSUE_TEMPLATE/suggest_wallet.md @@ -161,7 +161,7 @@ Before suggesting a wallet, make sure you've read [our listing policy](https://w -### Smart Contract +### Smart contract **Is the wallet a multi-signature wallet?** From 4acb0592bb8760978748f26122fe5a203fb85e8c Mon Sep 17 00:00:00 2001 From: Corwin Smith Date: Tue, 24 May 2022 21:20:15 -0600 Subject: [PATCH 30/55] Update .github/ISSUE_TEMPLATE/suggest_wallet.md Co-authored-by: Joshua <62268199+minimalsm@users.noreply.github.com> --- .github/ISSUE_TEMPLATE/suggest_wallet.md | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/.github/ISSUE_TEMPLATE/suggest_wallet.md b/.github/ISSUE_TEMPLATE/suggest_wallet.md index 92783d062fa..5eef3340fb2 100644 --- a/.github/ISSUE_TEMPLATE/suggest_wallet.md +++ b/.github/ISSUE_TEMPLATE/suggest_wallet.md @@ -173,6 +173,11 @@ Before suggesting a wallet, make sure you've read [our listing policy](https://w ### Support +**Does the wallet have a person the ethereum.org team can contact regarding the wallet in future?** + + + + **Does your wallet have a dedicated support team?** From 9a0ac4c17e31fd18b7be7d1c660c5b1938398259 Mon Sep 17 00:00:00 2001 From: Corwin Smith Date: Thu, 26 May 2022 09:29:29 -0600 Subject: [PATCH 31/55] Update .github/ISSUE_TEMPLATE/suggest_wallet.md Co-authored-by: Joshua <62268199+minimalsm@users.noreply.github.com> --- .github/ISSUE_TEMPLATE/suggest_wallet.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/ISSUE_TEMPLATE/suggest_wallet.md b/.github/ISSUE_TEMPLATE/suggest_wallet.md index 5eef3340fb2..fb9c25195b8 100644 --- a/.github/ISSUE_TEMPLATE/suggest_wallet.md +++ b/.github/ISSUE_TEMPLATE/suggest_wallet.md @@ -173,7 +173,7 @@ Before suggesting a wallet, make sure you've read [our listing policy](https://w ### Support -**Does the wallet have a person the ethereum.org team can contact regarding the wallet in future?** +**Who can the ethereum.org team can contact regarding the wallet in future?** From d26024eaf2224337132c9f3bc5debbf5245e3bf0 Mon Sep 17 00:00:00 2001 From: Corwin Smith Date: Thu, 26 May 2022 09:29:36 -0600 Subject: [PATCH 32/55] Update .github/ISSUE_TEMPLATE/suggest_wallet.md Co-authored-by: Joshua <62268199+minimalsm@users.noreply.github.com> --- .github/ISSUE_TEMPLATE/suggest_wallet.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/ISSUE_TEMPLATE/suggest_wallet.md b/.github/ISSUE_TEMPLATE/suggest_wallet.md index fb9c25195b8..f0b19c328d9 100644 --- a/.github/ISSUE_TEMPLATE/suggest_wallet.md +++ b/.github/ISSUE_TEMPLATE/suggest_wallet.md @@ -178,7 +178,7 @@ Before suggesting a wallet, make sure you've read [our listing policy](https://w -**Does your wallet have a dedicated support team?** +**Does the wallet have a dedicated support team?** From b2069603b38d6052517ea974a3883de0efea54cd Mon Sep 17 00:00:00 2001 From: Corwin Smith Date: Thu, 26 May 2022 09:29:46 -0600 Subject: [PATCH 33/55] Update .github/ISSUE_TEMPLATE/suggest_wallet.md Co-authored-by: Joshua <62268199+minimalsm@users.noreply.github.com> --- .github/ISSUE_TEMPLATE/suggest_wallet.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/ISSUE_TEMPLATE/suggest_wallet.md b/.github/ISSUE_TEMPLATE/suggest_wallet.md index f0b19c328d9..fc7e6556107 100644 --- a/.github/ISSUE_TEMPLATE/suggest_wallet.md +++ b/.github/ISSUE_TEMPLATE/suggest_wallet.md @@ -181,7 +181,7 @@ Before suggesting a wallet, make sure you've read [our listing policy](https://w **Does the wallet have a dedicated support team?** - + **What educational resources/documentation do you provide to users?** From 23bfea0b2d3caf562af741923c574b09f1323c44 Mon Sep 17 00:00:00 2001 From: Corwin Smith Date: Thu, 26 May 2022 09:29:53 -0600 Subject: [PATCH 34/55] Update .github/ISSUE_TEMPLATE/suggest_wallet.md Co-authored-by: Joshua <62268199+minimalsm@users.noreply.github.com> --- .github/ISSUE_TEMPLATE/suggest_wallet.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/ISSUE_TEMPLATE/suggest_wallet.md b/.github/ISSUE_TEMPLATE/suggest_wallet.md index fc7e6556107..a4e633e74bf 100644 --- a/.github/ISSUE_TEMPLATE/suggest_wallet.md +++ b/.github/ISSUE_TEMPLATE/suggest_wallet.md @@ -95,7 +95,7 @@ Before suggesting a wallet, make sure you've read [our listing policy](https://w **Please describe the measures taken to ensure the wallet's security and provide documentation wherever possible** - + **Spam protection?** From cba7469fd62080c902878d2a06137fa55f39096a Mon Sep 17 00:00:00 2001 From: Corwin Smith Date: Thu, 26 May 2022 09:30:02 -0600 Subject: [PATCH 35/55] Update .github/ISSUE_TEMPLATE/suggest_wallet.md Co-authored-by: Joshua <62268199+minimalsm@users.noreply.github.com> --- .github/ISSUE_TEMPLATE/suggest_wallet.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/ISSUE_TEMPLATE/suggest_wallet.md b/.github/ISSUE_TEMPLATE/suggest_wallet.md index a4e633e74bf..114a80c331e 100644 --- a/.github/ISSUE_TEMPLATE/suggest_wallet.md +++ b/.github/ISSUE_TEMPLATE/suggest_wallet.md @@ -91,7 +91,7 @@ Before suggesting a wallet, make sure you've read [our listing policy](https://w - + **Please describe the measures taken to ensure the wallet's security and provide documentation wherever possible** From fdf119dc81f1339b1a4fd6d5c90701f99cdb92dd Mon Sep 17 00:00:00 2001 From: Corwin Smith Date: Thu, 26 May 2022 09:41:28 -0600 Subject: [PATCH 36/55] Update .github/ISSUE_TEMPLATE/suggest_wallet.md Co-authored-by: Joshua <62268199+minimalsm@users.noreply.github.com> --- .github/ISSUE_TEMPLATE/suggest_wallet.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/ISSUE_TEMPLATE/suggest_wallet.md b/.github/ISSUE_TEMPLATE/suggest_wallet.md index 114a80c331e..0533dc11d3a 100644 --- a/.github/ISSUE_TEMPLATE/suggest_wallet.md +++ b/.github/ISSUE_TEMPLATE/suggest_wallet.md @@ -47,7 +47,7 @@ Before suggesting a wallet, make sure you've read [our listing policy](https://w -**Is your wallet globally accessible?** +**Is the wallet globally accessible?** From c1f887637647e0696519b49aa38ea3f76e5faa11 Mon Sep 17 00:00:00 2001 From: Corwin Smith Date: Thu, 26 May 2022 09:41:37 -0600 Subject: [PATCH 37/55] Update .github/ISSUE_TEMPLATE/suggest_wallet.md Co-authored-by: Joshua <62268199+minimalsm@users.noreply.github.com> --- .github/ISSUE_TEMPLATE/suggest_wallet.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/ISSUE_TEMPLATE/suggest_wallet.md b/.github/ISSUE_TEMPLATE/suggest_wallet.md index 0533dc11d3a..6dab3a51b6f 100644 --- a/.github/ISSUE_TEMPLATE/suggest_wallet.md +++ b/.github/ISSUE_TEMPLATE/suggest_wallet.md @@ -49,7 +49,7 @@ Before suggesting a wallet, make sure you've read [our listing policy](https://w **Is the wallet globally accessible?** - + **Is the wallet available in multiple languages?** From 0c0b6a32a4a5d4de573eb9850831537741b0da3c Mon Sep 17 00:00:00 2001 From: Corwin Smith Date: Thu, 26 May 2022 09:41:50 -0600 Subject: [PATCH 38/55] Update .github/ISSUE_TEMPLATE/suggest_wallet.md Co-authored-by: Joshua <62268199+minimalsm@users.noreply.github.com> --- .github/ISSUE_TEMPLATE/suggest_wallet.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/ISSUE_TEMPLATE/suggest_wallet.md b/.github/ISSUE_TEMPLATE/suggest_wallet.md index 6dab3a51b6f..342768c5dc8 100644 --- a/.github/ISSUE_TEMPLATE/suggest_wallet.md +++ b/.github/ISSUE_TEMPLATE/suggest_wallet.md @@ -43,7 +43,7 @@ Before suggesting a wallet, make sure you've read [our listing policy](https://w -**Does your wallet have an active development team?** +**Does the wallet have an active development team?** From a557f4272ae0026c06213fa2085f78b00bc4640e Mon Sep 17 00:00:00 2001 From: Corwin Smith Date: Thu, 26 May 2022 09:42:00 -0600 Subject: [PATCH 39/55] Update .github/ISSUE_TEMPLATE/suggest_wallet.md Co-authored-by: Joshua <62268199+minimalsm@users.noreply.github.com> --- .github/ISSUE_TEMPLATE/suggest_wallet.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/ISSUE_TEMPLATE/suggest_wallet.md b/.github/ISSUE_TEMPLATE/suggest_wallet.md index 342768c5dc8..09377c3cc64 100644 --- a/.github/ISSUE_TEMPLATE/suggest_wallet.md +++ b/.github/ISSUE_TEMPLATE/suggest_wallet.md @@ -39,7 +39,7 @@ Before suggesting a wallet, make sure you've read [our listing policy](https://w -**When did your wallet go live to users?** +**When did the wallet go live to users?** From b4b5654fc3486acd713f5e8fa1c8f05c1222a02a Mon Sep 17 00:00:00 2001 From: Corwin Smith Date: Thu, 26 May 2022 09:42:14 -0600 Subject: [PATCH 40/55] Update .github/ISSUE_TEMPLATE/suggest_wallet.md Co-authored-by: Joshua <62268199+minimalsm@users.noreply.github.com> --- .github/ISSUE_TEMPLATE/suggest_wallet.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/ISSUE_TEMPLATE/suggest_wallet.md b/.github/ISSUE_TEMPLATE/suggest_wallet.md index 09377c3cc64..f14fee53e6c 100644 --- a/.github/ISSUE_TEMPLATE/suggest_wallet.md +++ b/.github/ISSUE_TEMPLATE/suggest_wallet.md @@ -6,7 +6,7 @@ labels: "wallet :purse:," assignees: "" --- -Before suggesting a wallet, make sure you've read [our listing policy](https://www.ethereum.org/en/contributing/adding-products/). Only continue with the issue if your wallet meets the criteria listed there. +Before suggesting a wallet, make sure you've read [our listing policy](https://www.ethereum.org/en/contributing/adding-products/). Only continue with the issue if the wallet meets the criteria listed there. ### Project info From c1de7a780a0e2f6a3c8ad582fc5e7ac40f51a4cf Mon Sep 17 00:00:00 2001 From: Corwin Smith Date: Thu, 26 May 2022 09:42:21 -0600 Subject: [PATCH 41/55] Update .github/ISSUE_TEMPLATE/suggest_wallet.md Co-authored-by: Joshua <62268199+minimalsm@users.noreply.github.com> --- .github/ISSUE_TEMPLATE/suggest_wallet.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/ISSUE_TEMPLATE/suggest_wallet.md b/.github/ISSUE_TEMPLATE/suggest_wallet.md index f14fee53e6c..6275a36f884 100644 --- a/.github/ISSUE_TEMPLATE/suggest_wallet.md +++ b/.github/ISSUE_TEMPLATE/suggest_wallet.md @@ -37,7 +37,7 @@ Before suggesting a wallet, make sure you've read [our listing policy](https://w **Is the wallet security tested? Please explain security measures i.e. security audit, internal security team, or some other method.** - + **When did the wallet go live to users?** From 2002de2e490ee43ebe05030858f19ed8036563bc Mon Sep 17 00:00:00 2001 From: Corwin Smith Date: Thu, 26 May 2022 14:47:20 -0600 Subject: [PATCH 42/55] change requests --- .github/ISSUE_TEMPLATE/suggest_wallet.md | 20 ++++++++++++++------ 1 file changed, 14 insertions(+), 6 deletions(-) diff --git a/.github/ISSUE_TEMPLATE/suggest_wallet.md b/.github/ISSUE_TEMPLATE/suggest_wallet.md index 6275a36f884..0f3ec96532a 100644 --- a/.github/ISSUE_TEMPLATE/suggest_wallet.md +++ b/.github/ISSUE_TEMPLATE/suggest_wallet.md @@ -8,7 +8,6 @@ assignees: "" Before suggesting a wallet, make sure you've read [our listing policy](https://www.ethereum.org/en/contributing/adding-products/). Only continue with the issue if the wallet meets the criteria listed there. - ### Project info **Wallet name** @@ -35,10 +34,6 @@ Before suggesting a wallet, make sure you've read [our listing policy](https://w -**Is the wallet security tested? Please explain security measures i.e. security audit, internal security team, or some other method.** - - - **When did the wallet go live to users?** @@ -97,6 +92,18 @@ Before suggesting a wallet, make sure you've read [our listing policy](https://w +**Has the wallet's smart contract code been audited?** + + + +**Does the wallet have an internal security team?** + + + +**Any other security testing that should be noted?** + + + **Spam protection?** @@ -176,7 +183,7 @@ Before suggesting a wallet, make sure you've read [our listing policy](https://w **Who can the ethereum.org team can contact regarding the wallet in future?** - + **Does the wallet have a dedicated support team?** @@ -186,6 +193,7 @@ Before suggesting a wallet, make sure you've read [our listing policy](https://w **What educational resources/documentation do you provide to users?** + ### Extra **Does the wallet have any integrated tools not mentioned above?** From bec25f3a4ae74ce00959f40c2dda88a1c5e266e5 Mon Sep 17 00:00:00 2001 From: Corwin Smith Date: Thu, 26 May 2022 15:02:33 -0600 Subject: [PATCH 43/55] setup yaml --- .github/ISSUE_TEMPLATE/suggest_wallet.yaml | 9 +++++++++ 1 file changed, 9 insertions(+) create mode 100644 .github/ISSUE_TEMPLATE/suggest_wallet.yaml diff --git a/.github/ISSUE_TEMPLATE/suggest_wallet.yaml b/.github/ISSUE_TEMPLATE/suggest_wallet.yaml new file mode 100644 index 00000000000..9226a34df61 --- /dev/null +++ b/.github/ISSUE_TEMPLATE/suggest_wallet.yaml @@ -0,0 +1,9 @@ +name: Suggest a wallet +about: Suggest a new wallet to list on ethereum.org +title: "" +labels: ["wallet :purse:,"] +assignees: "" +body: + - type: markdown + attributes: + value: Before suggesting a wallet, make sure you've read [our listing policy](https://www.ethereum.org/en/contributing/adding-products/). Only continue with the issue if the wallet meets the criteria listed there. From f52c997d063ef869f21afb101c2f85b7266fcb31 Mon Sep 17 00:00:00 2001 From: Corwin Smith Date: Thu, 26 May 2022 15:09:51 -0600 Subject: [PATCH 44/55] test commit --- .github/ISSUE_TEMPLATE/suggest_wallet.yaml | 16 ++++++++++++---- 1 file changed, 12 insertions(+), 4 deletions(-) diff --git a/.github/ISSUE_TEMPLATE/suggest_wallet.yaml b/.github/ISSUE_TEMPLATE/suggest_wallet.yaml index 9226a34df61..b67f2af1515 100644 --- a/.github/ISSUE_TEMPLATE/suggest_wallet.yaml +++ b/.github/ISSUE_TEMPLATE/suggest_wallet.yaml @@ -1,9 +1,17 @@ name: Suggest a wallet -about: Suggest a new wallet to list on ethereum.org -title: "" +description: Suggest a new wallet to list on ethereum.org +title: Suggest a wallet labels: ["wallet :purse:,"] -assignees: "" body: - type: markdown attributes: - value: Before suggesting a wallet, make sure you've read [our listing policy](https://www.ethereum.org/en/contributing/adding-products/). Only continue with the issue if the wallet meets the criteria listed there. + value: | + Before suggesting a wallet, make sure you've read [our listing policy](https://www.ethereum.org/en/contributing/adding-products/). Only continue with the issue if the wallet meets the criteria listed there. + - type: input + id: contact + attributes: + label: Contact Details + description: How can we get in touch with you if we need more info? + placeholder: ex. email@example.com + validations: + required: false From 778982dd6d351962dea79e86a8a01645a163a1d4 Mon Sep 17 00:00:00 2001 From: Corwin Smith Date: Thu, 26 May 2022 15:13:43 -0600 Subject: [PATCH 45/55] test --- .github/ISSUE_TEMPLATE/suggest_wallet.yaml | 13 ++++++++----- 1 file changed, 8 insertions(+), 5 deletions(-) diff --git a/.github/ISSUE_TEMPLATE/suggest_wallet.yaml b/.github/ISSUE_TEMPLATE/suggest_wallet.yaml index b67f2af1515..a53e3a1586c 100644 --- a/.github/ISSUE_TEMPLATE/suggest_wallet.yaml +++ b/.github/ISSUE_TEMPLATE/suggest_wallet.yaml @@ -7,11 +7,14 @@ body: attributes: value: | Before suggesting a wallet, make sure you've read [our listing policy](https://www.ethereum.org/en/contributing/adding-products/). Only continue with the issue if the wallet meets the criteria listed there. - - type: input + - type: markdown id: contact attributes: - label: Contact Details - description: How can we get in touch with you if we need more info? - placeholder: ex. email@example.com + value: "## Project info" + - type: input + id: wallet_name + attributes: + label: Wallet name + placeholder: Please provide the official name of the wallet validations: - required: false + required: true From b615e9bb645332ec268b700aebaa6693816153ae Mon Sep 17 00:00:00 2001 From: Corwin Smith Date: Thu, 26 May 2022 15:27:57 -0600 Subject: [PATCH 46/55] project info form --- .github/ISSUE_TEMPLATE/suggest_wallet.yaml | 67 +++++++++++++++++++++- 1 file changed, 65 insertions(+), 2 deletions(-) diff --git a/.github/ISSUE_TEMPLATE/suggest_wallet.yaml b/.github/ISSUE_TEMPLATE/suggest_wallet.yaml index a53e3a1586c..ef620be96bb 100644 --- a/.github/ISSUE_TEMPLATE/suggest_wallet.yaml +++ b/.github/ISSUE_TEMPLATE/suggest_wallet.yaml @@ -1,7 +1,7 @@ name: Suggest a wallet description: Suggest a new wallet to list on ethereum.org title: Suggest a wallet -labels: ["wallet :purse:,"] +labels: ["wallet :purse:"] body: - type: markdown attributes: @@ -15,6 +15,69 @@ body: id: wallet_name attributes: label: Wallet name - placeholder: Please provide the official name of the wallet + description: Please provide the official name of the wallet. + validations: + required: true + - type: textarea + id: wallet_description + attributes: + label: Wallet description + description: Please provide a short 1-2 sentence description of the wallet. Avoid unsubstantiated marketing claims like “the best Ethereum wallet”. + validations: + required: true + - type: textarea + id: wallet_logo + attributes: + label: Wallet logo + description: | + Please provide an SVG or hi-res transparent PNG + Tip: You can attach images by clicking this area to highlight it and then dragging files in. + validations: + required: true + - type: input + id: wallet_background + attributes: + label: Background color for brand logo + description: Please provide a hex code for the brand color. This will be added to the background of the wallet card. + validations: + required: true + - type: input + id: wallet_url + attributes: + label: URL to the project + description: Please provide a URL (e.g. to the website of the wallet). + validations: + required: true + - type: input + id: wallet_live_date + attributes: + label: When did the wallet go live to users? + description: Please provide a date when the wallet was usable by the public + validations: + required: true + - type: input + id: wallet_active_development_team + attributes: + label: Does the wallet have an active development team? + description: Are developers actively working on the wallet? Provide proof that the wallet is actively being worked on (ex. GitHub repo link). + validations: + required: true + - type: input + id: wallet_globally_accessible + attributes: + label: Is the wallet globally accessible? + description: Please list any KYC requirements or geographic limitations of the wallet, if any exist. + validations: + required: true + - type: input + id: wallet_languages + attributes: + label: Is the wallet available in multiple languages? + description: Please list languages that the wallet actively supports. + - type: textarea + id: wallet_socials + attributes: + label: What social links are there for the project? + description: Please provide social links for the wallet (Discord, Twitter, etc.) validations: required: true From 39d4a75f48d00d8bc04d9404a27d5f03c804ac68 Mon Sep 17 00:00:00 2001 From: Corwin Smith Date: Thu, 26 May 2022 15:38:20 -0600 Subject: [PATCH 47/55] device form --- .github/ISSUE_TEMPLATE/suggest_wallet.yaml | 26 +++++++++++++++++++++- 1 file changed, 25 insertions(+), 1 deletion(-) diff --git a/.github/ISSUE_TEMPLATE/suggest_wallet.yaml b/.github/ISSUE_TEMPLATE/suggest_wallet.yaml index ef620be96bb..b5d9cd310d3 100644 --- a/.github/ISSUE_TEMPLATE/suggest_wallet.yaml +++ b/.github/ISSUE_TEMPLATE/suggest_wallet.yaml @@ -8,7 +8,7 @@ body: value: | Before suggesting a wallet, make sure you've read [our listing policy](https://www.ethereum.org/en/contributing/adding-products/). Only continue with the issue if the wallet meets the criteria listed there. - type: markdown - id: contact + id: project_info attributes: value: "## Project info" - type: input @@ -81,3 +81,27 @@ body: description: Please provide social links for the wallet (Discord, Twitter, etc.) validations: required: true + - type: markdown + id: device + attributes: + value: "## Device" + - type: textarea + id: wallet_mobile + attributes: + label: Does the wallet have a mobile app? If yes, which operating systems are supported (iOS, Android)? + description: Please provide app store links for the operating systems supported. + - type: textarea + id: wallets_desktop + attributes: + label: Does the wallet have a desktop app? If yes, which operating systems are supported (Windows, Mac, Linux)? + description: Please provide links and information for the desktop operating systems supported. + - type: textarea + id: wallets_browser + attributes: + label: Does the wallet have a browser extension? If yes, which browsers are supported (Chromium, Firefox, Safari)? + description: Please provide links and information for the browsers that are supported. + - type: textarea + id: wallets_hardware + attributes: + label: Is it a hardware wallet? + description: How does it broadcast signed transactions (e.g. USB, Bluetooth, QR code)? From 0e3f0892cf2564d0f4663eeadb4570061f213dfc Mon Sep 17 00:00:00 2001 From: Corwin Smith Date: Thu, 26 May 2022 16:11:46 -0600 Subject: [PATCH 48/55] security form --- .github/ISSUE_TEMPLATE/suggest_wallet.yaml | 48 ++++++++++++++++++++++ 1 file changed, 48 insertions(+) diff --git a/.github/ISSUE_TEMPLATE/suggest_wallet.yaml b/.github/ISSUE_TEMPLATE/suggest_wallet.yaml index b5d9cd310d3..7ce1e24c6ee 100644 --- a/.github/ISSUE_TEMPLATE/suggest_wallet.yaml +++ b/.github/ISSUE_TEMPLATE/suggest_wallet.yaml @@ -105,3 +105,51 @@ body: attributes: label: Is it a hardware wallet? description: How does it broadcast signed transactions (e.g. USB, Bluetooth, QR code)? + - type: markdown + id: security + attributes: + value: "## Security" + - type: input + id: wallet_source_code + attributes: + label: Is the source code for the wallet fully open-source? + description: If yes, please provide a direct link to the repository. + - type: input + id: wallet_license + attributes: + label: What license is the wallet software released under? + description: Please provide information on the software license used for the wallet. + - type: textarea + id: wallet_custodial + attributes: + label: Who holds the private keys? + description: | + Users must have access to private keys without reliance on a company remaining in business to be listed as a wallet. + Do users have access to their public and private keys? Does anyone else? If the company/project were to disappear, would users still be able to access their funds? + validations: + required: true + - type: textarea + id: wallet_security_documentation + attributes: + label: Please describe the measures taken to ensure the wallet's security and provide documentation wherever possible + description: Please provide a link to any security audits, code reports, and bug bounties. If you haven't been audited but think the wallet should be listed anyway, explain here. + - type: input + id: wallet_smart_contract_audit + attributes: + label: Has the wallet's smart contract code been audited? + description: If yes, provide a link to any audits. + - type: input + id: wallet_security_team + attributes: + label: Does the wallet have an internal security team? + description: If yes, please provide details. + - type: textarea + id: wallet_security_testing + attributes: + label: Any other security testing that should be noted? + description: Please note any other security precautions taken. + - type: textarea + id: wallet_spam_protection + attributes: + label: Spam protection? + description: Does the wallet employ any practices to warn users against potential spam (e.g. when interacting with suspicious accounts/contracts)? From 60a5bffa4030e21b1e13c61ea5c01b9e7562d159 Mon Sep 17 00:00:00 2001 From: Corwin Smith Date: Thu, 26 May 2022 16:23:49 -0600 Subject: [PATCH 49/55] features form --- .github/ISSUE_TEMPLATE/suggest_wallet.yaml | 76 ++++++++++++++++++++++ 1 file changed, 76 insertions(+) diff --git a/.github/ISSUE_TEMPLATE/suggest_wallet.yaml b/.github/ISSUE_TEMPLATE/suggest_wallet.yaml index 7ce1e24c6ee..e7f88ea78ef 100644 --- a/.github/ISSUE_TEMPLATE/suggest_wallet.yaml +++ b/.github/ISSUE_TEMPLATE/suggest_wallet.yaml @@ -153,3 +153,79 @@ body: attributes: label: Spam protection? description: Does the wallet employ any practices to warn users against potential spam (e.g. when interacting with suspicious accounts/contracts)? + - type: markdown + id: features + attributes: + value: "## Features" + - type: dropdown + id: wallet_hardware_support + attributes: + label: Does the wallet support connecting to a hardware wallet? + options: + - Yes + - No + validations: + required: true + - type: dropdown + id: wallet_walletconnect + attributes: + label: Does the wallet support WalletConnect? + options: + - Yes + - No + validations: + required: true + - type: input + id: wallet_rpc_importing + attributes: + label: Does the wallet support importing Ethereum RPC endpoints? + description: Please provide documentation on how a user can import an Ethereum RPC into the wallet. + - type: dropdown + id: wallet_nft_viewing + attributes: + label: Does the wallet support viewing and interacting with NFTs? + options: + - Yes + - No + validations: + required: true + - type: input + id: wallet_dapp_support + attributes: + label: Does the wallet support connecting to Ethereum applications? + description: Please provide documentation for how users connect to applications. List examples (ie. connect wallet to dapp, in wallet browser, etc.) + - type: input + id: wallet_direct_staking + attributes: + label: Does the wallet support staking directly? + description: Please provide documentation on direct staking this wallet supports. + - type: input + id: wallet_swaps + attributes: + label: Does the wallet support swaps directly? + description: Please provide documentation on swaps. + - type: input + id: wallet_multi_chain_support + attributes: + label: Does the wallet support multi-chain networks? + description: Please provide documentation on multi-chain networks this wallet supports. + - type: input + id: wallet_customize_gas_fees + attributes: + label: Does the wallet allow the user to customize gas fees? + description: Please provide documentation on how users can customize gas fees for transactions. + - type: input + id: wallet_ens_support + attributes: + label: Does the wallet support sending transactions to ENS addresses? + description: Please provide information on ENS support. + - type: input + id: wallet_erc_20_support + attributes: + label: Does the wallet support importing or automatically querying and displaying ERC-20 tokens? + description: Please provide documentation on how to import tokens into the wallet. + - type: input + id: wallet_eip_1559_support + attributes: + label: Does the wallet support EIP-1559 (type 2) transactions? + description: Please provide information on how the type of transactions this wallet supports. From ee947558c6e041ade69790b19004bda67240136a Mon Sep 17 00:00:00 2001 From: Corwin Smith Date: Thu, 26 May 2022 16:24:56 -0600 Subject: [PATCH 50/55] fix features bugs --- .github/ISSUE_TEMPLATE/suggest_wallet.yaml | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/.github/ISSUE_TEMPLATE/suggest_wallet.yaml b/.github/ISSUE_TEMPLATE/suggest_wallet.yaml index e7f88ea78ef..e01a2f7a414 100644 --- a/.github/ISSUE_TEMPLATE/suggest_wallet.yaml +++ b/.github/ISSUE_TEMPLATE/suggest_wallet.yaml @@ -162,8 +162,8 @@ body: attributes: label: Does the wallet support connecting to a hardware wallet? options: - - Yes - - No + - "Yes" + - "No" validations: required: true - type: dropdown @@ -171,8 +171,8 @@ body: attributes: label: Does the wallet support WalletConnect? options: - - Yes - - No + - "Yes" + - "No" validations: required: true - type: input @@ -185,8 +185,8 @@ body: attributes: label: Does the wallet support viewing and interacting with NFTs? options: - - Yes - - No + - "Yes" + - "No" validations: required: true - type: input From f358eaa6d75560b9994539ce2360634f07ed8b26 Mon Sep 17 00:00:00 2001 From: Corwin Smith Date: Thu, 26 May 2022 16:28:23 -0600 Subject: [PATCH 51/55] finance form --- .github/ISSUE_TEMPLATE/suggest_wallet.yaml | 16 +++++++++++++++- 1 file changed, 15 insertions(+), 1 deletion(-) diff --git a/.github/ISSUE_TEMPLATE/suggest_wallet.yaml b/.github/ISSUE_TEMPLATE/suggest_wallet.yaml index e01a2f7a414..0c0595296ec 100644 --- a/.github/ISSUE_TEMPLATE/suggest_wallet.yaml +++ b/.github/ISSUE_TEMPLATE/suggest_wallet.yaml @@ -228,4 +228,18 @@ body: id: wallet_eip_1559_support attributes: label: Does the wallet support EIP-1559 (type 2) transactions? - description: Please provide information on how the type of transactions this wallet supports. + description: Please provide information on the type of transactions this wallet supports. + - type: markdown + id: finance + attributes: + value: "## Finance" + - type: input + id: wallet_fiat_onramp + attributes: + label: Does the wallet have fiat on-ramps through credit/debit cards, wire transfers, or bank transfers (ACH)? + description: Please provide documentation on how a user is able to onboard and purchase crypto in the wallet. + - type: input + id: wallet_fiat_withdrawals + attributes: + label: Does the wallet support withdrawals to fiat? + description: an a user cash out their crypto assets directly to a card or bank account? Please provide documentation. From 1246f99157abc30b27e9e05386e0a893d08bc648 Mon Sep 17 00:00:00 2001 From: Corwin Smith Date: Thu, 26 May 2022 16:34:14 -0600 Subject: [PATCH 52/55] smart contract form --- .github/ISSUE_TEMPLATE/suggest_wallet.yaml | 14 ++++++++++++++ 1 file changed, 14 insertions(+) diff --git a/.github/ISSUE_TEMPLATE/suggest_wallet.yaml b/.github/ISSUE_TEMPLATE/suggest_wallet.yaml index 0c0595296ec..636b210bb29 100644 --- a/.github/ISSUE_TEMPLATE/suggest_wallet.yaml +++ b/.github/ISSUE_TEMPLATE/suggest_wallet.yaml @@ -243,3 +243,17 @@ body: attributes: label: Does the wallet support withdrawals to fiat? description: an a user cash out their crypto assets directly to a card or bank account? Please provide documentation. + - type: markdown + id: smart_contract + attributes: + value: "## Smart contract" + - type: input + id: wallet_multi_signature + attributes: + label: Is the wallet a multi-signature wallet? + description: Please provide documentation on how users set up and use the multisig functionality for the wallet. + - type: input + id: wallet_social_recovery + attributes: + label: Does the wallet support social recovery? + description: Please provide documentation on how users set up guardians and use social recovery for the wallet. From 1a52f3985938e89c81165fb319b917c46a418759 Mon Sep 17 00:00:00 2001 From: Corwin Smith Date: Thu, 26 May 2022 16:37:28 -0600 Subject: [PATCH 53/55] support form --- .github/ISSUE_TEMPLATE/suggest_wallet.yaml | 23 ++++++++++++++++++++++ 1 file changed, 23 insertions(+) diff --git a/.github/ISSUE_TEMPLATE/suggest_wallet.yaml b/.github/ISSUE_TEMPLATE/suggest_wallet.yaml index 636b210bb29..46cf0296836 100644 --- a/.github/ISSUE_TEMPLATE/suggest_wallet.yaml +++ b/.github/ISSUE_TEMPLATE/suggest_wallet.yaml @@ -257,3 +257,26 @@ body: attributes: label: Does the wallet support social recovery? description: Please provide documentation on how users set up guardians and use social recovery for the wallet. + - type: markdown + id: support + attributes: + value: "## Support" + - type: textarea + id: wallet_contact + attributes: + label: Who can the ethereum.org team can contact regarding the wallet in future? + description: | + If possible, provide a Telegram, Discord, or Twitter username. + Please note that as a result of any future dispute the wallet may be temporarily removed from ethereum.org. Having a contact person allows lets us avoid this situation and resolve issues more quickly. + - type: textarea + id: wallet_support_team + attributes: + label: Does the wallet have a dedicated support team? + description: | + Where should we send users that are having issues? + How fast is the support? + - type: textarea + id: wallet_educational_resources + attributes: + label: What educational resources/documentation do you provide to users? + description: Please provide links to developer documentation, user documentation, and/or educational resources. From 08de2bc8c545217cb771f313581e089891155de4 Mon Sep 17 00:00:00 2001 From: Corwin Smith Date: Thu, 26 May 2022 16:38:40 -0600 Subject: [PATCH 54/55] extra form --- .github/ISSUE_TEMPLATE/suggest_wallet.yaml | 9 +++++++++ 1 file changed, 9 insertions(+) diff --git a/.github/ISSUE_TEMPLATE/suggest_wallet.yaml b/.github/ISSUE_TEMPLATE/suggest_wallet.yaml index 46cf0296836..ed051c406c4 100644 --- a/.github/ISSUE_TEMPLATE/suggest_wallet.yaml +++ b/.github/ISSUE_TEMPLATE/suggest_wallet.yaml @@ -280,3 +280,12 @@ body: attributes: label: What educational resources/documentation do you provide to users? description: Please provide links to developer documentation, user documentation, and/or educational resources. + - type: markdown + id: extra + attributes: + value: "## Extra" + - type: textarea + id: wallet_extra + attributes: + label: Does the wallet have any integrated tools not mentioned above? + description: Please provide any information about extra features this wallet has that we may have missed in the above criteria. (e.g. privacy features, transaction batching, etc). From 193a3ebdefe0495e130766d63de96f2b51097790 Mon Sep 17 00:00:00 2001 From: Corwin Smith Date: Mon, 30 May 2022 10:48:27 -0600 Subject: [PATCH 55/55] remove md issue template --- .github/ISSUE_TEMPLATE/suggest_wallet.md | 201 ----------------------- 1 file changed, 201 deletions(-) delete mode 100644 .github/ISSUE_TEMPLATE/suggest_wallet.md diff --git a/.github/ISSUE_TEMPLATE/suggest_wallet.md b/.github/ISSUE_TEMPLATE/suggest_wallet.md deleted file mode 100644 index 0f3ec96532a..00000000000 --- a/.github/ISSUE_TEMPLATE/suggest_wallet.md +++ /dev/null @@ -1,201 +0,0 @@ ---- -name: Suggest a wallet -about: Suggest a new wallet to list on ethereum.org -title: "" -labels: "wallet :purse:," -assignees: "" ---- - -Before suggesting a wallet, make sure you've read [our listing policy](https://www.ethereum.org/en/contributing/adding-products/). Only continue with the issue if the wallet meets the criteria listed there. - -### Project info - -**Wallet name** - - - -**Wallet description** - - - -**Wallet logo** - - - -**Background color for brand logo** - - - -**URL to the project** - - - -**URL to the documentation** - - - -**When did the wallet go live to users?** - - - -**Does the wallet have an active development team?** - - - -**Is the wallet globally accessible?** - - - -**Is the wallet available in multiple languages?** - - - -**What social links are there for the project?** - - - -### Device - -**Does the wallet have a mobile app? If yes, which operating systems are supported (iOS, Android)?** - - - -**Does the wallet have a desktop app? If yes, which operating systems are supported (Windows, Mac, Linux)?** - - - -**Does the wallet have a browser extension? If yes, which browsers are supported (Chromium, Firefox, Safari)?** - - - -**Is it a hardware wallet?** - - - -### Security - -**Is the source code for the wallet fully open-source?** - - - -**What license is the wallet software released under?** - - - -**Who holds the private keys?** - - - - - -**Please describe the measures taken to ensure the wallet's security and provide documentation wherever possible** - - - -**Has the wallet's smart contract code been audited?** - - - -**Does the wallet have an internal security team?** - - - -**Any other security testing that should be noted?** - - - -**Spam protection?** - - - -### Features - -**Does the wallet support connecting to a hardware wallet?** - - - -**Does the wallet support WalletConnect?** - - - -**Does the wallet support importing Ethereum RPC endpoints?** - - - -**Does the wallet support viewing and interacting with NFTs?** - - - -**Does the wallet support connecting to Ethereum applications?** - - - -**Does the wallet support staking directly?** - - - -**Does the wallet support swaps directly?** - - - -**Does the wallet support multi-chain networks?** - - - -**Does the wallet allow the user to customize gas fees?** - - - -**Does the wallet support sending transactions to ENS addresses?** - - - -**Does the wallet support importing or automatically querying and displaying ERC-20 tokens?** - - - -**Does the wallet support EIP-1559 (type 2) transactions?** - - - -### Finance - -**Does the wallet have fiat on-ramps through credit/debit cards, wire transfers, or bank transfers (ACH)?** - - - -**Does the wallet support withdrawals to fiat?** - - - -### Smart contract - -**Is the wallet a multi-signature wallet?** - - - -**Does the wallet support social recovery?** - - - -### Support - -**Who can the ethereum.org team can contact regarding the wallet in future?** - - - - -**Does the wallet have a dedicated support team?** - - - - -**What educational resources/documentation do you provide to users?** - - - -### Extra - -**Does the wallet have any integrated tools not mentioned above?** - -