Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🧪(gentest): add testing to ci for the gentest cli #860

Open
Tracked by #866
danceratopz opened this issue Oct 2, 2024 · 0 comments
Open
Tracked by #866

🧪(gentest): add testing to ci for the gentest cli #860

danceratopz opened this issue Oct 2, 2024 · 0 comments
Labels
scope:gentest Scope: gentest CLI type:test Type: Test

Comments

@danceratopz
Copy link
Member

danceratopz commented Oct 2, 2024

The gentest CLI currently has no test coverage - it could break at any time (perhaps due to changes in ethereum_test_rpc).

While we can see whether we can also add some unit tests for gentest, I would prioritize an end-to-end test that generates tests and then fills (and potentially consumes) them.

uv run gentest -c config.json 0xa41f343be7a150b740e5c939fa4d89f3a2850dbe21715df96b612fc20d1906be tests/paris/test_0xa41f.py
uv run fill  tests/paris/test_0xa41f.py
uv run consume direct -k test_0xa41f --evm-bin=path/to/evm-with-statetest

Few considerations for CI:

  • gentest requires a full-node RPC endpoint and will require secrets in CI
  • Should it be included in tox/tox_verify.yaml or have a dedicated Workflow? Perhaps add a new gentest environment in to tox.ini, but don't run it by default, it must be called via uvx --with=tox-uv tox -e gentest?
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
scope:gentest Scope: gentest CLI type:test Type: Test
Projects
None yet
Development

No branches or pull requests

1 participant