Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ethereumjs t8n fill compatibility #883

Open
winsvega opened this issue Oct 8, 2024 · 2 comments · Fixed by ethereumjs/ethereumjs-monorepo#3728
Open

ethereumjs t8n fill compatibility #883

winsvega opened this issue Oct 8, 2024 · 2 comments · Fixed by ethereumjs/ethereumjs-monorepo#3728
Labels
t8ntools Third party t8n tools support

Comments

@winsvega
Copy link
Collaborator

winsvega commented Oct 8, 2024

test_valid_blob_tx_combinations[fork_Cancun-blockchain_test-blobs_per_tx_(1, 1, 1, 3)] ______________________________________________
[gw2] linux -- Python 3.12.3 /home/wins/Ethereum/execution-spec-tests/.venv/bin/python3
tests/cancun/eip4844_blobs/test_blob_txs.py:604: in test_valid_blob_tx_combinations
    blockchain_test(
src/pytest_plugins/filler/filler.py:805: in __init__
    fixture = self.generate(
src/ethereum_test_specs/blockchain.py:750: in generate
    return self.make_fixture(t8n, fork, eips)
src/ethereum_test_specs/blockchain.py:568: in make_fixture
    header, txs, requests, new_alloc, new_env = self.generate_block_data(
src/ethereum_test_specs/blockchain.py:488: in generate_block_data
    block.header_verify.verify(header)
src/ethereum_test_specs/blockchain.py:212: in verify
    assert value == baseline_value, (
E   AssertionError: invalid header field (excess_blob_gas) value, got 0x00, want 0xe0000
E   assert 0 == 917504

not sure if its our side or theirs. the tool seem not be able to parse the input.
pyspecs branch exception_mapper

uv run fill --evm-bin=ethereumjs-t8n "tests/cancun/eip4844_blobs/test_blob_txs.py::test_valid_blob_tx_combinations[fork_Cancun-blockchain_test-blobs_per_tx_(1, 1, 1, 1, 1, 1)]"
@jochem-brouwer
Copy link
Member

The problem is on our side and is fixed by: ethereumjs/ethereumjs-monorepo#3728

(At least, this specific test)

@jochem-brouwer
Copy link
Member

We merged the fix, I think this issue could be closed :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
t8ntools Third party t8n tools support
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants