Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Mixing bignumber.js and native bigint #429

Closed
AuHau opened this issue Nov 22, 2022 · 0 comments · Fixed by #518
Closed

Mixing bignumber.js and native bigint #429

AuHau opened this issue Nov 22, 2022 · 0 comments · Fixed by #518
Labels
issue

Comments

@AuHau
Copy link
Contributor

AuHau commented Nov 22, 2022

In some places we are using bignumber.js's BigInt and in others the native one. I would suggest then dropping bignumber.js as NodeJS should support bigint in all supported versions...
@bee-runner bee-runner bot added the issue label Nov 22, 2022
@Cafe137 Cafe137 linked a pull request Jun 26, 2024 that will close this issue
refactor: remove bignumber.js dependency #518
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
issue
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

refactor: remove bignumber.js dependency ethersphere/swarm-cli
1 participant
@AuHau