Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LimitTransform #37

Closed
Mr-Geekman opened this issue Aug 14, 2023 · 0 comments · Fixed by #63
Closed

LimitTransform #37

Mr-Geekman opened this issue Aug 14, 2023 · 0 comments · Fixed by #63
Assignees
Labels
enhancement New feature or request priority/high High priority task

Comments

@Mr-Geekman
Copy link

Issue by Mr-Geekman
Monday Jul 17, 2023 at 12:29 GMT
Originally opened as tinkoff-ai#1316


🚀 Feature Request

Create a transform that limits values of some feature between the borders.

Proposal

Create LimitTransform.

Parameters:

  • in_column: column to make transformation on;

  • lower_bound: lower bound for the value of the column; -infty by default;

  • upper_bound: upper bound for the value of the column; +infty by default;

  • If there is value out of limit the exception should be raised.

  • NaNs should be ignored.

Reference: Ensure time series forecasts stay within limits.

To discuss:

  • Should this transform work for non-target column?
    • It should
  • Should this transform have inplace parameter for working in non-inplace mode?
    • Not, it shoudn't
  • Is there a better name for this transform?
    • Suggested name is ok

Test cases

What should be checked:

  • Working on non-target column
  • Working on target column
    • It should make inverse transformation for quantiles
  • Working with set/unset lower/upper values
  • Exception on out-of-limit value
  • Full pipeline that predicts some arbitrary values can be used
  • Full backtest with pipeline that uses this transform

Don't forget to add inference tests into tests/test_transforms/test_inference/.

Additional context

No response

@Mr-Geekman Mr-Geekman added enhancement New feature or request priority/high High priority task labels Aug 14, 2023
@Mr-Geekman Mr-Geekman moved this to Todo in etna board Aug 15, 2023
@martins0n martins0n moved this from Todo to In Progress in etna board Aug 24, 2023
@egoriyaa egoriyaa self-assigned this Aug 24, 2023
@egoriyaa egoriyaa mentioned this issue Aug 29, 2023
4 tasks
@alex-hse-repository alex-hse-repository moved this from In Progress to In Review in etna board Aug 31, 2023
@github-project-automation github-project-automation bot moved this from In Review to Done in etna board Sep 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request priority/high High priority task
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

2 participants