Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename method TSDataset.index -> TSDataset.timetamps and make it read-only #564

Closed
d-a-bunin opened this issue Jan 16, 2025 · 2 comments · Fixed by #593
Closed

Rename method TSDataset.index -> TSDataset.timetamps and make it read-only #564

d-a-bunin opened this issue Jan 16, 2025 · 2 comments · Fixed by #593
Assignees
@ArtemLiA
Milestone
Major release 3.0

Comments

@d-a-bunin
Copy link
Collaborator

🚀 Task description

There are two problems with current TSDataset.index:

  • It returns ts.df.index and could be changed inplace
  • It's name exposes inner structure for the users

Plan

  • Rename TSDataset.index to TSDataset.timestamps
  • Make it return self.df.index.copy()
  • Fix all places where ts.index was used and replace them with ts.timestamps

Test cases

No response

Additional context

No response
@d-a-bunin d-a-bunin added this to the Major release 3.0 milestone Jan 16, 2025
@d-a-bunin d-a-bunin moved this from New to Todo in etna board Jan 16, 2025
@ArtemLiA
Copy link

Hi! Can I do this?

@d-a-bunin
Copy link
Collaborator Author

I'm assigning you to this task for now. It will be reassigned if time will come to finish the milestone in a short amount of time.

@ArtemLiA ArtemLiA mentioned this issue Jan 31, 2025
Merged
4 tasks
@d-a-bunin d-a-bunin moved this from Todo to In Review in etna board Feb 3, 2025
@github-project-automation github-project-automation bot moved this from In Review to Done in etna board Feb 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ArtemLiA ArtemLiA

Labels
None yet
Projects
etna board
Status: Done
Milestone
Major release 3.0
2 participants
@ArtemLiA @d-a-bunin