Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Split this project up into the separate branches. #7

Open
boonya opened this issue Jan 11, 2016 · 6 comments
Open

Split this project up into the separate branches. #7

boonya opened this issue Jan 11, 2016 · 6 comments
Assignees

Comments

@boonya
Copy link
Contributor

boonya commented Jan 11, 2016

I'd prefer to split current project on two different branches like: master (just pure vim with basic configurations) and python (vim for python development)
It can be useful for people who want to have precofigured vim for their servers and so on.
By this way we can add more branches for different goals in the future.

@rmk135
Copy link
Member

rmk135 commented Jan 11, 2016

It's interesting idea... Let's start with discussion!

One thing, that I'm 100% sure is that the name of current repository should be something like PY.VIMRC, but not VIMRC (in case we will live it with the current content).

The number one question here is what do you propose to include in "just pure vim with basic configurations"?

@boonya
Copy link
Contributor Author

boonya commented Jan 11, 2016

"Pure vim" - it is something like this one https://github.com/boonya/vimrc/tree/without-python
But I'd like to add NerdTree a bit later and couple of other useful plugins.

@boonya
Copy link
Contributor Author

boonya commented Jan 11, 2016

Here https://github.com/boonya/vimrc/blob/without-python/vimrc#L28 you can see only tree plugins:

  • VundleVim/Vundle.vim
  • flazz/vim-colorschemes
  • bling/vim-airline

And nothing about specific customisation like virtualenv, jinja, python-pep8-indent and so on...

@rmk135
Copy link
Member

rmk135 commented Jan 11, 2016

I think that it makes sense, but how do you think about having 2 separate repos for that - VIMRC & PYVIMRC?

Or how do you see usage of 2 separate branches for this?

I'm asking because my initial idea was to create environment for the python developers only and I'm not very familial with other guy tasks and their needs.

@boonya
Copy link
Contributor Author

boonya commented Jan 11, 2016

About two separate branches... We can use command like git clone -b python --single-branch https://github.com/ets-labs/vimrc.git ~/.vim for checkout on only one specific branch. It should work with Git 1.7.10 and later. For older versions of Git git clone -b python https://github.com/ets-labs/vimrc.git ~/.vim.

And I'm not really sure regarding to separate repos. It is still VIM but with different plugins.

@rmk135
Copy link
Member

rmk135 commented Jan 11, 2016

Ok, gotcha! So, here is my proposal:

  • Move all python specific plugins / options to separate file (something like vimrc_mod_python).
  • Rename setup script from init.sh to setup.sh.
  • Put optional param for setup script that will define required config's content - setup.sh python or setup.sh basic / add special step that will ask user about required config's content.
  • Put source vimrc_mod_python (it works like include directive) into vimrc during the installation process based on user's needs.

PS

Just a few thoughts about previous ideas:

  • I do agree that the idea of having different repos for python and basic configuration is no the best one.
  • I'm not sure that the idea of having two separate branches can work well for all cases. For example, if we make some common change that is suitable for both functionalities, we should always keep in mind to cherry-pick in both branches. May be I miss something here, if the problem is not relevant, please, let me know.
  • I do not like different ways of cloning repo based on client git's version. If there is a solution that works for everybody - we should use it.

@rmk135 rmk135 removed the question label Jan 14, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants