Set production or development in conditions

[benmccann]

It would be nice if conditions always included development or production

E.g. vite build will automatically set the production condition while vite dev will automatically set the development condition

References:
https://vite.dev/config/shared-options#resolve-conditions
https://vite.dev/guide/env-and-mode#node-env-and-modes

Libraries like Svelte rely on this to be set. This works automatically in Vite, but requires extra configuration in esbuild

If the user has not provided either production or development then set production by default or development if NODE_ENV === 'development'

[hyrious]

esbuild doesn't check NODE_ENV in its Go code. It does set process.env.NODE_ENV = "production" when all minification options are enabled. Maybe the same logic can be applied to the conditions field.

[benmccann]

That seems reasonable as conditions and NODE_ENV should always be in sync as it would cause confusion to have their values differ