Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Export comments #184

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

Conversation

MaxGhenis
Copy link

@MaxGhenis MaxGhenis commented Dec 24, 2024

Fixes #20

I haven't yet tested this.

@evbacher
Copy link
Owner

Thanks for this suggestion -- a couple of comments/questions:

  • We're not currently accepting contributions, as we're trying to add some enhancements. We'll try to evaluate this when we have some time.
  • How does this change render the comments in the output? The main purpose of Docs to Markdown is to publish finished content to Markdown or HTML. Comments are not usually part of published output.
  • It seems as though you've made many code/style changes that do not relate to exporting comments.
  • If not tested, we're loathe to proceed.

On the other hand, don't spend too much time on this right now, since we're not ready to spend time on our end. If we do come back to this, we'll let you know.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Export comments
2 participants