Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Addtional information for contributors #165

Open
deloarts opened this issue Oct 12, 2023 · 2 comments
Open

Addtional information for contributors #165

deloarts opened this issue Oct 12, 2023 · 2 comments
Assignees

Comments

@deloarts
Copy link
Contributor

deloarts commented Oct 12, 2023

@evereux: Maybe add additional information to the contributing chapter in the readme for people who want to contribute to pycatia:

  • how to format the code
  • how to sort imports
  • what line length limit is defined
  • create pull requests to the development branch only (*edited)
  • something else?

For everyone who uses VS Code, add this to your workspace settings to match pycatias formatting:

{
    "[python]": {
        "editor.rulers": [
            120
        ],
        "editor.formatOnSave": true,
        "editor.codeActionsOnSave": {
            "source.organizeImports": true
        },
        "editor.defaultFormatter": "ms-python.black-formatter"
    },
    "pylint.args": [
        "--line-length",
        "120"
    ],
    "black-formatter.args": [
        "--line-length",
        "120"
    ],
    "isort.args": [
        "--profile",
        "black",
        "-sl"
    ],
    "python.testing.pytestArgs": [
        "tests/in"
    ]
}

Note: This requires the following extensions:

@evereux
Copy link
Owner

evereux commented Oct 12, 2023

The CONTRIBUTING.md file which is linked to in the README.md is the better place for this kind of thing. It already covers some of this. Which people aren't likely to read anyway from my experience. 😄

No VSCode settings though as the information should be applicable regardless of IDE.

@deloarts
Copy link
Contributor Author

Yes, the contributing.md is the better place for that (and yes, I didn't read it ...).

No VSCode settings though as the information should be applicable regardless of IDE.

I didn't mean to add the VS Code settings to the contributing file, I just left it here in the issue so others can apply the pycatia-formatting-rules directly to their workspace.

evereux added a commit that referenced this issue Oct 17, 2023
 and referred to existing examples for code formatting #165
evereux added a commit that referenced this issue Jun 29, 2024
 and referred to existing examples for code formatting #165
evereux added a commit that referenced this issue Jun 29, 2024
 and referred to existing examples for code formatting #165
siddhu2310 pushed a commit to siddhu2310/pycatia that referenced this issue Aug 20, 2024
 and referred to existing examples for code formatting evereux#165
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants