Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Errors in script "02_Генеральная уборка.js" #222

Open
alzhur opened this issue Jun 3, 2018 · 4 comments
Open

Errors in script "02_Генеральная уборка.js" #222

alzhur opened this issue Jun 3, 2018 · 4 comments

Comments

@alzhur
Copy link

alzhur commented Jun 3, 2018

  1. Fast-fix for issue Ошибка в скрипте "02_Генеральная уборка.js" #197 not working, looks like typo. Details in my comment to that issue.
  2. Additional rule re06a required: replace ndash symbol inside the word with hyphen, or else ndash will be replaced with mdash (by rule re07) and surrounded by spaces by other rules, effectively turning string "some-thing" into "some — thing".
    My fast-fix for this issue (designed and tested for russian texts only) in attached file.
    fast-fix.txt
@evpobr
Copy link
Owner

evpobr commented Jun 3, 2018

Can you make pull request? I would be very nice.

@alzhur
Copy link
Author

alzhur commented Jun 4, 2018

I'll try (never done that before), but looks like I need more rights to do so, no way to create branch for my edits without write permission or something.

@evpobr
Copy link
Owner

evpobr commented Jun 4, 2018

You don't need access to my repo, create your own copy (fork) right here on GitHub. See that Fork button? Press is to start 😄

Read "Fork a repo" article and try it, I will help if you need.

alzhur added a commit to alzhur/fictionbookeditor that referenced this issue Jun 5, 2018
@alzhur
Copy link
Author

alzhur commented Jun 5, 2018

I hope I did it right 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants