Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HTTPS support #64

Open
AratKruglik opened this issue Feb 21, 2024 · 8 comments · Fixed by #69
Open

HTTPS support #64

AratKruglik opened this issue Feb 21, 2024 · 8 comments · Fixed by #69
Labels
enhancement New feature or request

Comments

@AratKruglik
Copy link

Does laravel-octane-dockerfile support HTTPS connection?
How to use HTTPS?

@smortexa
Copy link
Member

I have not used HTTPS with these Dockerfiles.

@smortexa smortexa added the question Further information is requested label Feb 24, 2024
@AratKruglik
Copy link
Author

So it's hard to use for production then (

@tudorr89
Copy link

tudorr89 commented Mar 3, 2024

So it's hard to use for production then (

Just put it behind reverse proxy and handle https there.

@deantomasevic
Copy link

Just put it behind reverse proxy and handle https there.

franken already supports https, so it would be useful if it can be used without reverse proxy

@tommmoe
Copy link

tommmoe commented Mar 16, 2024

So it's hard to use for production then (

Following the FrankenPHP instructions, you're meant to set the SERVER_NAME env, also running octane with the --https switch actually changes the server running prefix:

   INFO  Server running…

  Local: https://localhost:443

But I get

WARN  installing root certificate (you might be prompted for password)
ERROR  failed to install root certificate

While I can get in via "https" it's not getting a certificate possibly due to the failure to install the root cert..

@smortexa smortexa mentioned this issue Apr 9, 2024
smortexa added a commit that referenced this issue Apr 9, 2024
Fixes #64
Prevents laravel/octane#791
Potentially fix for #66
@tommmoe
Copy link

tommmoe commented May 14, 2024

@smortexa any ideas why i still get

2024-05-14 21:32:06 WARN installing root certificate (you might be prompted for password)
2024-05-14 21:32:06
2024-05-14 21:32:06 ERROR failed to install root certificate
2024-05-14 21:32:06
2024-05-14 21:32:06 WARN stapling OCSP

with the latest release?

@smortexa
Copy link
Member

@tommmoe There seems to be a conflict between FrankenPHP requiring root access for certificate installation and our Dockerfile using a non-root user.

@smortexa smortexa reopened this May 16, 2024
@smortexa smortexa added enhancement New feature or request and removed question Further information is requested labels May 16, 2024
@abdhashem
Copy link

@smortexa Do you recommend any way to bypass this issue without switching to root user in the Dockerfile?

Is there any security concerns if we switched to the root user in the docker file?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants