From 41300020e55c3d66ac215878aaec835af7c02024 Mon Sep 17 00:00:00 2001
From: Alexis Montoison <35051714+amontoison@users.noreply.github.com>
Date: Thu, 14 Mar 2024 21:24:52 +0100
Subject: [PATCH] Test more options for symmetric factorizations (#19)

---
 test/test_cudss.jl | 16 ++++++++--------
 1 file changed, 8 insertions(+), 8 deletions(-)

diff --git a/test/test_cudss.jl b/test/test_cudss.jl
index c9dd184..50ea65c 100644
--- a/test/test_cudss.jl
+++ b/test/test_cudss.jl
@@ -139,7 +139,7 @@ function cudss_execution()
 
     symmetric_hermitian_pivots = T <: Real ? ('C', 'R', 'N') : ('N',)
     @testset "Symmetric -- Hermitian" begin
-      @testset "view = $view" for view in ('F',)
+      @testset "view = $view" for view in ('F', 'L', 'U')
         @testset "Pivoting = $pivot" for pivot in symmetric_hermitian_pivots
           A_cpu = sprand(T, n, n, 0.01) + I
           A_cpu = A_cpu + A_cpu'
@@ -170,7 +170,7 @@ function cudss_execution()
     end
 
     @testset "SPD -- HPD" begin
-      @testset "view = $view" for view in ('F',)
+      @testset "view = $view" for view in ('F', 'L', 'U')
         @testset "Pivoting = $pivot" for pivot in ('C', 'R', 'N')
           A_cpu = sprand(T, n, n, 0.01)
           A_cpu = A_cpu * A_cpu' + I
@@ -246,7 +246,7 @@ function cudss_generic()
     end
 
     @testset "Symmetric -- Hermitian" begin
-      @testset "view = $view" for view in ('F',)
+      @testset "view = $view" for view in ('F', 'L', 'U')
         A_cpu = sprand(T, n, n, 0.01) + I
         A_cpu = A_cpu + A_cpu'
         B_cpu = rand(T, n, p)
@@ -262,7 +262,7 @@ function cudss_generic()
 
           solver = ldlt(A_gpu; view)
           ldiv!(X_gpu, solver, B_gpu)
-          R_gpu = B_gpu - A_gpu * X_gpu
+          R_gpu = B_gpu - CuSparseMatrixCSR(A_cpu) * X_gpu
           @test norm(R_gpu) ≤ √eps(R)
 
           c = rand(R)
@@ -279,7 +279,7 @@ function cudss_generic()
         @testset "\\" begin
           solver = ldlt(A_gpu; view)
           X_gpu = solver \ B_gpu
-          R_gpu = B_gpu - A_gpu * X_gpu
+          R_gpu = B_gpu - CuSparseMatrixCSR(A_cpu) * X_gpu
           @test norm(R_gpu) ≤ √eps(R)
 
           c = rand(R)
@@ -295,7 +295,7 @@ function cudss_generic()
     end
 
     @testset "SPD -- HPD" begin
-      @testset "view = $view" for view in ('F',)
+      @testset "view = $view" for view in ('F', 'L', 'U')
         A_cpu = sprand(T, n, n, 0.01)
         A_cpu = A_cpu * A_cpu' + I
         B_cpu = rand(T, n, p)
@@ -311,7 +311,7 @@ function cudss_generic()
 
           solver = cholesky(A_gpu; view)
           ldiv!(X_gpu, solver, B_gpu)
-          R_gpu = B_gpu - A_gpu * X_gpu
+          R_gpu = B_gpu - CuSparseMatrixCSR(A_cpu) * X_gpu
           @test norm(R_gpu) ≤ √eps(R)
 
           c = rand(R)
@@ -328,7 +328,7 @@ function cudss_generic()
         @testset "\\" begin
           solver = cholesky(A_gpu; view)
           X_gpu = solver \ B_gpu
-          R_gpu = B_gpu - A_gpu * X_gpu
+          R_gpu = B_gpu - CuSparseMatrixCSR(A_cpu) * X_gpu
           @test norm(R_gpu) ≤ √eps(R)
 
           c = rand(R)