Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Modify the delta vector direction when creating a single-cell mesh #273

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Modify the delta vector direction when creating a single-cell mesh #273

wants to merge 1 commit into from

Conversation

chihtaw
Copy link
Collaborator

@chihtaw chihtaw commented Mar 6, 2025 •
edited
Loading

Motivation

Delta vector is defined as the vector from cell center to cell face when there is only a single cell in the mesh.
https://doc.cfd.direct/notes/cfd-general-principles/boundary-mesh

Therefore, each delta vector should have the same direction as the corresponding face area vector.

@chihtaw chihtaw linked an issue Mar 6, 2025 that may be closed by this pull request
Seemingly wrong direction of delta vectors for the corresponding Sf vectors in the function createSingleCellMesh #171
Open
@chihtaw chihtaw requested a review from greole March 6, 2025 09:19
@github-actions GitHub Actions
Copy link

github-actions bot commented Mar 6, 2025

Deployed test documentation to https://exasim-project.com/NeoFOAM/Build_PR_273

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@greole greole Awaiting requested review from greole

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
1 participant
@chihtaw