Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve the code quality of the schema.column_type.ColumnType #240

Open
ahsimb opened this issue Dec 13, 2024 · 1 comment
Open

Improve the code quality of the schema.column_type.ColumnType #240

ahsimb opened this issue Dec 13, 2024 · 1 comment
Labels
refactoring Code improvement without behavior change

Comments

@ahsimb
Copy link
Contributor

ahsimb commented Dec 13, 2024

  1. No documentation at all. Does the name include the size and precision? God knows.
  2. If the name is not the full name then the full_name property would be very helpful.
  3. Consider implementing the __eq__ method for type comparison.
@ahsimb ahsimb added the refactoring Code improvement without behavior change label Dec 13, 2024
@ckunki
Copy link
Contributor

ckunki commented Dec 16, 2024

See linked ticket in IntRef for details

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
refactoring Code improvement without behavior change
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@ahsimb @ckunki