Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace find_object_proxies with a class #241

Open
ckunki opened this issue Dec 16, 2024 · 1 comment
Open

Replace find_object_proxies with a class #241

ckunki opened this issue Dec 16, 2024 · 1 comment
Labels
refactoring Code improvement without behavior change

Comments

@ckunki
Copy link
Contributor

ckunki commented Dec 16, 2024

Background

  • find_object_proxies suffered from a reuse of ids of temporary objects, which led to incomplete traversals of the object tree and with that to not found object proxies
  • To avoid this in the future, the following things are necessary
    • We need to keep all seen objects in a list to prevent the release of a temporary object until the function ends.
    • We need to implement limits on the depth and the number of seen objects to prevent to high memory use
    • We have to make sure the algorithm itself doesn't produce temporary objects.
    • Extract it to a class and a factory, to make it injectable and to make state handling easier. Through injection, we can also version with reporting for debugging.
@ckunki ckunki added the refactoring Code improvement without behavior change label Dec 16, 2024
@ckunki
Copy link
Contributor Author

ckunki commented Dec 16, 2024

Copied from (see IntRef)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
refactoring Code improvement without behavior change
Projects
None yet
Development

No branches or pull requests

1 participant