Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Integrate Type-Check into CI workflow(s) #43

Open
4 tasks
Nicoretti opened this issue Oct 23, 2024 · 0 comments
Open
4 tasks

Integrate Type-Check into CI workflow(s) #43

Nicoretti opened this issue Oct 23, 2024 · 0 comments
Labels
feature Product feature

Comments

@Nicoretti
Copy link
Member

Nicoretti commented Oct 23, 2024

Summary

Fix all type-check issues discovered using the command nox -s type-check. Once all issues have been addressed, update the check.yml workflow file to include type-check as a step for verification of PRs and other relevant workflow executions.

Details

The repository currently has type-check issues, and these need to be identified and resolved to improve code quality and maintainability. The command nox -s type-check can be used to detect these issues.

The goal is to:

  1. Run nox -s type-check to identify all type-check errors and warnings.
  2. Update code to resolve all discovered issues.
  3. Modify the check.yml workflow to include type-checking as a step for all PRs and other relevant checks.

An example of the type-check workflow step can be seen by running the following command tbx workflow show checks.

Task(s)

  • Run nox -s type-check to identify type-check issues.
  • Fix identified type-check issues in the codebase.
  • Update the check.yml workflow to include type-check as a step.
  • Ensure modified check.yml runs successfully with type-check on a test branch or fork.
@Nicoretti Nicoretti changed the title Enable type-check in CI Integrate Type-Check into CI workflow(s) Oct 23, 2024
@Nicoretti Nicoretti added refactoring Code improvement without behavior change feature Product feature and removed refactoring Code improvement without behavior change labels Oct 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature Product feature
Projects
None yet
Development

No branches or pull requests

1 participant