Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make AbstractSpawnTestEnvironment return DbOsExecFactory #365

Open
ckunki opened this issue Jul 19, 2023 · 0 comments
Open

Make AbstractSpawnTestEnvironment return DbOsExecFactory #365

ckunki opened this issue Jul 19, 2023 · 0 comments
Labels
feature New feature or request

Comments

@ckunki
Copy link
Contributor

ckunki commented Jul 19, 2023

As DbOsExecFactory is essential for executing commands inside the OS hosting the Exasol database in a generic way, the current ticket requests to enhance AbstractSpawnTestEnvironment to return an appropriate instance of this factory.

Currently AbstractSpawnTestEnvironment._spawn_database_and_test_container() returns a tuple (DatabaseInfo, ContainerInfo), which is forwarded across multiple private methods and finally returned by run_task():

def run_task():
    test_environment_info = yield from self._attempt_database_start()
    self.return_object(test_environment_info)
def _attempt_database_start():
    yield from self._start_database(attempt)
def _start_database():
   yield from self._spawn_database_and_test_container(...)
def _spawn_database_and_test_container(...):
   return database_info, test_container_info

Acceptance criteria

  1. method _executor_factory() is moved from class SpawnTestEnvironmentWithDockerDB to class WaitForTestDockerDatabase
  2. the task based on class WaitForTestDockerDatabase returns the factory
  3. class SpawnTestEnvironmentWithDockerDB returns the factory together with DatabaseInfo and ContainerInfo
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant