Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename environment variable #378

Open
ckunki opened this issue Oct 9, 2023 · 0 comments
Open

Rename environment variable #378

ckunki opened this issue Oct 9, 2023 · 0 comments
Labels
refactoring Code improvement without behavior change

Comments

@ckunki
Copy link
Contributor

ckunki commented Oct 9, 2023 •
edited
Loading

ITDE sets a list of environment variables which are regarded part of ITDE's interface to its users. Ticket #329 shipped with release 2.0.0 refactored these variables into file eitde/lib/test_environment/shell_variables.py and also changed the prefix from ENVIRONMENT_ to ITDE_.

Unfortunately the release notes do not mention this change as breaking from a user's perspective.

Additionally the refactoring did fix the typo in the name of variable DATABASE_CONTAINER_VOLUMNE_NAME (extra "N" after VOLUM).

The current ticket proposes to fix this typo.

Optionally with adding a second environment variable (still including the typo) for backward compatibility.
@ckunki ckunki added the refactoring Code improvement without behavior change label Oct 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
refactoring Code improvement without behavior change
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@ckunki