TypeError: no implicit conversion of Hash into String

[artsiompeshko]

Hi!

First of all, thanks for the amazing gem!

Issue

We recently faced with a huge spike of the following errors:

TypeError: no implicit conversion of Hash into String

and

TypeError: no implicit conversion of Symbol into Integer

That happens in two cases:

1. When we try to deserialize notification object using @notification = params[:record].to_notification in mailers when sending notifications from jobs (impl https://github.com/bensheldon/good_job).
2. When we try to access some data from params after deserialization.

Observations

The issue happens sporadically. If we retry the job with email sending it finally comes through after <=8 attempts 🤷‍♂️.

Environment

We are using ruby ruby-3.0.4, rails 7.0.4, noticed 1.6.2, good_job 3.16.1, and PgSQL 13.7.

[artsiompeshko]

Let me know if any additional context might be helpful to help with the investigation.

[artsiompeshko]

It's weird, but redeploying k8s pods resolved the issue for now. It can still happen sporadically. For those who use https://github.com/bensheldon/good_job#retries: a potential hotfix is to add auto-rerties on TypeError.