batch notifications with activejob and sidekiq

[madhums]

I am implementing noticed gem and I'd enjoy some advise/feedback considering best practices.

Let's say I have a Discussion model and it has many Posts. When someone posts on a discussion, all the people who have posted on it before should also be notified. I have a NewPostNotification noticed notification class. Use the after_create_commit on the Post model to trigger a job within which I'd loop through records and call NewPostNotification. (I am considering using ActiveJob with sidekiq)

Since noticed gem doesn't support batch notifications (yet), this is what I thought of. Can anyone give some feedback?

# app/models/post.rb
class Post < ApplicationRecord
  after_create_commit :trigger_new_post_notification_job

  private

  def trigger_new_post_notification_job
    NewPostNotificationJob.perform_later(id)
  end
end

# app/jobs/new_post_notification_job.rb
class NewPostNotificationJob < ApplicationJob
  queue_as :default

  def perform(post_id)
    post = Post.find(post_id)
    discussion = post.discussion

    # Loop through users who have posted on the discussion
    discussion.posts.each do |previous_post|
      user = previous_post.user
      NewPostNotification.with(post:).deliver_later(user:)
    end
  end
end

---

Edit: I see that we can use multiple recipients in deliver_later, this probably solves it for now. But still wonder how this will be if there are thousands of users.

Related:

• Batch Deliveries #89
• Introduce Bulk deliveries #127