Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Crosspiece make wrong parts #47

Open
Raulvgz opened this issue Dec 29, 2020 · 1 comment
Open

Crosspiece make wrong parts #47

Raulvgz opened this issue Dec 29, 2020 · 1 comment

Comments

@Raulvgz
Copy link

Raulvgz commented Dec 29, 2020

Using the Crosspiece function I get wrong parts like in the picture:

2020-12-28 22_50_52-FreeCAD 0 19

I use:
OS: Windows 10 (10.0)
Word size of OS: 64-bit
Word size of FreeCAD: 64-bit
Version: 0.19.23141 (Git)
Build type: Release
Branch: master
Hash: 0eba78d40096720f7a637a9a73c382a08b820bca
Python version: 3.8.6
Qt version: 5.12.5
Coin version: 4.0.0
OCC version: 7.4.0
Locale: Spanish/Spain (es_ES)

The example file is this:
TestLCI.zip

At the moment I "solved" the problem with this changes in "%username%AppData\Roaming\FreeCAD\Mod\LCInterlocking\lasercut\crosspart.py":

Known problem #43 Line 372:

else:
    remove_intersections(first_part, second_part, referential_faces, axis, True) #new line
    print ("AppData\\Roaming\\FreeCAD\\Mod\\LCInterlocking\\lasercut\\crosspart.py") #new line
    #raise ValueError("Not managed") #comment line

In Lines 290/292 add "*1.1" after "second_part.properties.thickness":

    second_box = make_cross_box(second_part.properties.thickness *1.1, second_box_y, height,
                                second_part.properties.node_type, second_part.properties.node_thickness)
    second_box = make_nodes_yz(second_box, second_part.properties.thickness *1.1, second_box_y, height,
                               second_part.properties.node_type, second_part.properties.node_thickness)

@execuc
Copy link
Owner

execuc commented Jan 3, 2021

Hello,

Thank you for the attached example. This solution looks good to me. I will modify the code as soon as I have time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants