add search for users #86
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spanjshiri
previously approved these changes
May 27, 2020
mchughmk
requested changes
May 28, 2020
ui/src/SearchResults.tsx
Outdated
| return ( | ||
| <div> | ||
| {" "} | ||
| <h3>{username}</h3> |
There was a problem hiding this comment.
H3 isn't really appropriate here. It may style it the way you want, but the heading tags have semantic meaning as headers. This isn't a header, it's data.
jphilly11
force-pushed
the
search-for-users
branch
from
3a681e1 to
bc5bd0c
Compare
Open
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added search functionality for users. If you enter anything into the search bar it will search for both memes and users with that criteria. If there are no memes or users with that then it will say there are no memes or users with that criteria. If only a user or a meme can be found but not the other then it will still display them both with a message for the empty one saying none can be found.