Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: ✨ Introduce logLevel to makeEnvPublic #143

Merged
merged 1 commit into from
Jan 14, 2025

Conversation

MaxAltena
Copy link
Contributor

This allows for setting a logLevel to the makeEnvPublic function. This makes it so that you can disable logging entirely or only the wished upon level (ie. when things 'error').

Closes #108

Let me know if any changes are required 🙏

@MaxAltena
Copy link
Contributor Author

@HofmannZ Would love for you to take a look at this 🙏

Copy link
Member

@HofmannZ HofmannZ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@MaxAltena
Copy link
Contributor Author

@HofmannZ It looks like the checks aren't being ran and reported, could you somehow restart those as those are required?

@gregorybolkenstijn
Copy link

It would be great to get this merged, is there anything blocking it?

@HofmannZ HofmannZ merged commit 20f5609 into expatfile:development Jan 14, 2025
2 checks passed
@expatfile-bot
Copy link
Member

🎉 This PR is included in version 3.3.0-alpha.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Option to disable logging when using makeEnvPublic
4 participants