Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Variable start timeout #50

Open
Cooldude2606 opened this issue Aug 25, 2020 · 0 comments
Open

Variable start timeout #50

Cooldude2606 opened this issue Aug 25, 2020 · 0 comments
Labels
Feature Request Request for a new feature to be added

Comments

@Cooldude2606
Copy link
Member

Feature overview
Name: Variable start timeout
TL;DR: The timeout while waiting for players should be dependent on the number of players remaning.

Details
Currently the timeout will last for 2 minutes regardless of the number of participants required to start the game, or the amount that are remaining. This should be changed so that the timeout does not start unless a minimum percentage is reach (maybe 50%) and then as less players are remaining the timeout is reduced.

Possible methods
Each time a participant is added or removed check_participant_count is called, during this call a new timeout can be created depending on the number of players and the start time. This will allow for fine control over the timeout without needing to check every tick for different condidtions to be met.

@Cooldude2606 Cooldude2606 added the Feature Request Request for a new feature to be added label Aug 25, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature Request Request for a new feature to be added
Projects
None yet
Development

No branches or pull requests

1 participant