Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

iOS deployment target was not taken from the configuration. #160

Open
proton1k opened this issue Feb 17, 2023 · 8 comments
Open

iOS deployment target was not taken from the configuration. #160

proton1k opened this issue Feb 17, 2023 · 8 comments
Labels
bug Something isn't working

Comments

@proton1k
Copy link

Summary

We're trying to build an ios app using eas build --platform ios in the project which contains a newly installed plugin "@config-plugins/react-native-webrtc",. We followed instructions in the really big and old thread about implementing WebRTC with Expo (link here). According to the recommendation, we need to install package expo-dev-client along with the @config-plugins/react-native-webrtc and according to the example offered for review, we did exactly as required. Due to having a failing build with traceback logs saying

compiling for iOS 12.0, but module 'ExpoModulesCore' has a minimum deployment target of iOS 13.0:

we added

  [
    "expo-build-properties",
    {
      "ios": {
        "deploymentTarget": "13.0"
      }
    }
  ]

to the app.json configuration, but it looks like it does not catch up in the eas build environment. We still get

❌  (node_modules/expo-linear-gradient/ios/LinearGradientModule.swift:4:8)

  2 | 
  3 | import CoreGraphics
> 4 | import ExpoModulesCore
    |        ^ compiling for iOS 12.0, but module 'ExpoModulesCore' has a minimum deployment target of iOS 13.0: /Users/expo/Library/Developer/Xcode/DerivedData/binaschoolapp-eykxagvjwynwjugxpprchszbfdvw/Build/Intermediates.noindex/ArchiveIntermediates/binaschoolapp/BuildProductsPath/Release-iphoneos/ExpoModulesCore/ExpoModulesCore.swiftmodule/arm64-apple-ios.swiftmodule

after adding this config instructions.

Config Plugin

@config-plugins/react-native-webrtc

What platform(s) does this occur on?

iOS

SDK Version

~47.0.12

Reproducible demo

Minumum reproducible example:
https://drive.proton.me/urls/Y4TY3DFGCM#NBcYtaD7q31N

1st failed build:
https://expo.dev/accounts/the_bina_school/projects/bina-app/builds/f0ad1db9-6a74-4585-b047-d01ec8a6fbd0

2nd failed build:
https://expo.dev/accounts/the_bina_school/projects/bina-app/builds/ec898bf2-a7c2-421d-a05b-ff2a7640208e

@proton1k proton1k added the bug Something isn't working label Feb 17, 2023
@zane-commeatio
Copy link

Same issue here

@Malachite40
Copy link

same

@GoldAndLink
Copy link

Did you find out a way to force the deploymentTarget ?

@tomhopkins
Copy link

@c-fitzmaurice
Copy link

Also looking for any update here I just ran into this as well when trying to include a third party pod in a custom native module

@GoldAndLink
Copy link

On my side I had to use npx expo prebuild -p ios --clean so I could generate a prebuild and force the target of the third party (NotificationService in my case) right into XCode

@MichaelDickinson20I
Copy link

I was having this issue and found that the native module I was trying to install had this line in the podspec:

s.platforms  = { :ios => '12.0', :tvos => '12.0' }

I set the version numbers there to 13, ran a clean prebuild, and the issue went away

@maryonella02
Copy link

On my side I had to use npx expo prebuild -p ios --clean so I could generate a prebuild and force the target of the third party (NotificationService in my case) right into XCode

This was the only thing that solved my problem too. Thanks a lot, @GoldAndLink!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

8 participants