Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Shouldn't all expo peer dependencies be updated to v52? #253

Open
NTag opened this issue Nov 13, 2024 · 1 comment
Open

Shouldn't all expo peer dependencies be updated to v52? #253

NTag opened this issue Nov 13, 2024 · 1 comment
Labels
bug Something isn't working

Comments

@NTag
Copy link

NTag commented Nov 13, 2024

Summary

When trying to upgrade to expo v52 in a project with @config-plugins/react-native-dynamic-app-icon, the following error appears:

npm error code ERESOLVE
npm error ERESOLVE could not resolve
npm error
npm error While resolving: @config-plugins/[email protected]
npm error Found: [email protected]
npm error node_modules/expo
npm error   expo@"^52.0.0" from the root project
npm error   peer expo@"*" from [email protected]
npm error   node_modules/expo-asset
npm error     expo-asset@"~11.0.1" from [email protected]
npm error   23 more (expo-keep-awake, ...)
npm error
npm error Could not resolve dependency:
npm error peer expo@"^51" from @config-plugins/[email protected]
npm error node_modules/@config-plugins/react-native-dynamic-app-icon
npm error   @config-plugins/react-native-dynamic-app-icon@"^8.0.0" from the root project
npm error
npm error Conflicting peer dependency: [email protected]
npm error node_modules/expo
npm error   peer expo@"^51" from @config-plugins/[email protected]
npm error   node_modules/@config-plugins/react-native-dynamic-app-icon
npm error     @config-plugins/react-native-dynamic-app-icon@"^8.0.0" from the root project

which isn't surprising because the peer dependency on expo for this package is ^51, like actually all the other packages in this repo.

I believe their package.json files should be updated to support the new expo release? Like it was done earlier this year when expo v51 was released: https://github.com/expo/config-plugins/pull/234/files.

Thank you very much 🙏

@NTag NTag added the bug Something isn't working label Nov 13, 2024
@NTag
Copy link
Author

NTag commented Nov 13, 2024

A temporary fix for those looking is to override the expo version in the package.json:

  "overrides": {
    "expo": "^52.0.0"
  },

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant