Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expo publish & preview action is very slow #190

Open
Dakuan opened this issue Aug 17, 2022 · 2 comments
Open

Expo publish & preview action is very slow #190

Dakuan opened this issue Aug 17, 2022 · 2 comments

Comments

@Dakuan
Copy link

Dakuan commented Aug 17, 2022

Description of the bug

exp publish is taking ~30mins to build a PR, seems to have happened in a recent expo update. Its less than a minute on my local machine (M1 macbook pro). As a result, all of our github minutes get munched in the first 48 hours of the month, making previews impossible.

To Reproduce

this is our github action config:

name: Create preview
on: [pull_request]
jobs:
  publish:
    runs-on: ubuntu-latest
    steps:
      - name: 🏗 Setup repo
        uses: actions/checkout@v2
      
      - name: Add Fortawesome token to npmrc
        run: echo -e "@fortawesome:registry=https://npm.fontawesome.com/\n//npm.fontawesome.com/:_authToken=${{ secrets.FONTAWESOME_AUTH_TOKEN }}" > .npmrc

      - name: 🏗 Setup Node
        uses: actions/setup-node@v2
        with:
          node-version: 16.x
          cache: yarn

      - name: 🏗 Setup Expo
        uses: expo/expo-github-action@v7
        with:
          expo-version: latest
          token: ${{ secrets.EXPO_TOKEN }}

      - name: 📦 Install dependencies
        run: yarn install

      - run: rm  ./assets/db/birda_geo_9.db.zip
      - run: mv ./assets/db/dummy.txt ./assets/db/birda_geo_9.db.zip

      - name: 🚀 Publish preview
        run: expo publish --release-channel=pr-${{ github.event.number }} --non-interactive
        env:
          EXPO_USE_DEV_SERVER: true
          ENABLE_NOTICES: true
          ENABLE_AUTH_PROXY: true
          ENABLE_PRIVACY_CONTROLS: true
          SKIP_ZIP: true

      - name: 💬 Comment preview
        uses: expo/expo-github-action/preview-comment@v7
        with:
          channel: pr-${{ github.event.number }}

Expected behavior

build in a reasonable time frame

Actual behavior

ate all my github minutes

Additional context

slowed down alot with expo 45

@PedroRestrepo
Copy link

I am experiencing the same issue. It got stuck for like 18 minutes on Starting Metro Bundler and overall took 22 minutes to run.

image

@byCedric
Copy link
Member

Hi! Sorry for the late reply. To confirm, is this happening only during the Metro bundling? Nothing has changed in the GH action itself, so I assume it's Metro itself. I'll take a look at possible performance regressions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants