Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Beta Updates Github hook on expo.dev doesn't trigger in monorepo when pushing multiple commits to branch #314

Open
aldebout opened this issue Nov 15, 2024 · 0 comments

Comments

@aldebout
Copy link

Not sure if this is the right repo to open this issue.

Description of the bug

When using the beta github hook for eas updates in a monorepo, if I push multiple commits at once to a branch and the last doesn't change files inside the expo app folder, the hook does not trigger.

To Reproduce

Activate the hook.
image

Commit multiple times locally, changing the app but not in the last commit.
image

Push to github.
image

Expected behavior

The hook runs, an update is published in the branch channel.

Actual behavior

Screenshot 2024-11-15 at 12 10 54 PM

Additional context

I'm not 100% sure about how to repro but I'll update if I find out more.
If I push a commit that does have changes in the expo folder, the updates hook triggers as expected.

@aldebout aldebout changed the title Beta Updates Github hook on expo.dev doesn't trigger in monorepo when pushing directly to branch Beta Updates Github hook on expo.dev doesn't trigger in monorepo when pushing multiple commits to branch Nov 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant