Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: update template with expresso/core and inversify #16

Merged
merged 2 commits into from
Apr 28, 2024

Conversation

rsaz
Copy link
Member

@rsaz rsaz commented Apr 27, 2024

Pull Request Guidelines

Our guidelines for submitting a pull request.

Before submitting a Pull Request, please make sure you have verified the following:

  • The commit message follows our guidelines:
    • A good commit message should be two things: meaningful and concise. It should not contain every single detail, describing each changed line—we can see all the changes in Git—but, at the same time, it should say enough to avoid ambiguity.
    • We use Microverse's commit message convention
    • The convention stablish that a commit message has to be in the present tense, imperative and lowercase.
    • Example: fix typo in README.md
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Other... Please describe:

What is the current behavior?

Please describe the current behavior that you are modifying, or link to a relevant issue.
N/A
Issue Number: N/A

What is the new behavior?

Describe the new behavior or link to a relevant issue.

  • Included packages inversify for make the @injectable decorator available
  • Added @expresso/core to make the IProvider interface available

Does this PR introduce a breaking change?

  • Yes
  • No

If this PR contains a breaking change, please describe the impact and migration path for existing applications below.

Other information

Any other information that is important to this PR.

@rsaz rsaz self-assigned this Apr 27, 2024
@rsaz rsaz added the enhancement New feature or request label Apr 27, 2024
@rsaz rsaz merged commit f530ce2 into main Apr 28, 2024
3 checks passed
@rsaz rsaz deleted the feature/update-template-inversify-expresso-core branch April 28, 2024 00:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant